fix: restore legend visibility in format_string_demo #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legend visibility was being reset to false during figure re-initialization in the savefig process, causing legends to disappear from all outputs (PNG, PDF, TXT). This happened because: 1. legend() correctly set show_legend = true 2. savefig() deallocated/reallocated the backend 3. ensure_global_figure_initialized() called fig.initialize() 4. initialize() reset show_legend = false (the bug) 5. render_figure() saw show_legend = false and skipped legend The fix preserves existing legend settings during re-initialization by removing the automatic reset. Initial legend state is already correctly initialized to false when the figure is first created. This fixes legend visibility in format_string_demo and all other examples that use legends across all output formats. Fixes #331 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
krystophny
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes legend visibility issue where the legend was not displayed in format_string_demo despite show_legend being set to true.
Root Cause
The figure re-initialization logic in
figure_plot_mod.f90was unconditionally resettingshow_legend = .false.during every call toinitialize(), overriding user settings.Solution
Removed the automatic reset of
show_legendduring figure re-initialization, allowing the user's legend visibility preference to persist across plot operations.Changes
src/figure_plot_mod.f90: Removedthis%show_legend = .false.from the initialize subroutinelegend()methodTesting
Verified that:
Fixes #331