Skip to content

Deleting Development Branch#38

Merged
kirkhess merged 140 commits intomasterfrom
development
Sep 20, 2018
Merged

Deleting Development Branch#38
kirkhess merged 140 commits intomasterfrom
development

Conversation

@kirkhess
Copy link
Copy Markdown
Contributor

A lot of changed files...let me know if you see any issues.

Note: index.html uses config.js and the minified js (bfe.min.js).

kirkhess and others added 30 commits April 5, 2018 15:58
Remove profiles from bfe source. Towards #13.
Add bootstrap popover that contains resource ID.
@cledvina
Copy link
Copy Markdown
Collaborator

This works for me. I am experiencing some problems with the "Home / Editor" links at the top of the page. The urls start with "/bibliomata" now. I don't think this will be a problem other than when starting development.

So the question is... Where do we make bfe changes? /src/bfe.js? And then run grunt?

@kirkhess
Copy link
Copy Markdown
Contributor Author

kirkhess commented Sep 19, 2018

This works for me. I am experiencing some problems with the "Home / Editor" links at the top of the page.

Hmm - well, there's no base url for bfe like there is for the profile editor. That might be a new issue but I'll switch it back to how it was before.

So the question is... Where do we make bfe changes? /src/bfe.js? And then run grunt?

Yes.

Copy link
Copy Markdown
Collaborator

@cledvina cledvina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah-- I guess this works pretty nicely.

@kirkhess kirkhess merged commit b4dd79a into master Sep 20, 2018
@kirkhess kirkhess deleted the development branch September 20, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants