Experimental recoil generation - #315
Merged
Merged
Conversation
Collaborator
Author
…nto improved_duff
Improved duff
… the github ci runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Thank you for your contribution to rustBCA!
Before submitting this PR, please make sure you have:
Fixes #314, #302
Description
This PR swaps out the custom derived formulas for constructing an orthonormal basis for recoil generation and particle deflection with Duff et al.'s robust formula.
This also rolls in improvements to input validation and rolls-back the electronic stopping change - probably BV stopping needs two different ck for each energy regime?
Tests
cargo testpasses with modification to tests.rs for the new orthonormal bases;test_cube.pyreproduces the correct behavior. Other results all seem identical within statistical error.This will break the seeded rng tests.