Skip to content

Conversation

@kinke
Copy link
Member

@kinke kinke commented Nov 15, 2015

No description provided.

@smolt
Copy link
Member

smolt commented Nov 15, 2015

Just out of curiosity to improve my feeble brain. This PR is referring to a commit on a phobos PR branch. Do you have to redo it after the phobos PR is merged? Otherwise it would be referring to a commit not the the ldc branch, right?

@kinke
Copy link
Member Author

kinke commented Nov 15, 2015

I don't really know. :)
I created a Phobos branch on the official remote so that I can test it with this LDC-PR. I'm not sure whether I can just transplant (cherry-pick?) the single Phobos commit to the ldc branch, keeping its hash (in case there are no further changes on the ldc branch). In that case, I could just merge this PR; otherwise, I'll have to push a new commit to LDC master (or rebase this PR).
I don't know what the better approach is - merging the Phobos-PR and pushing a LDC commit or doing it the other way around, pushing to Phobos and merging an LDC-PR. Ideally, we'd 'just' ;) have proper CI tests for druntime and Phobos too.

@kinke kinke force-pushed the phobosMath branch 10 times, most recently from b0593fb to 200f250 Compare November 17, 2015 00:38
@kinke
Copy link
Member Author

kinke commented Nov 22, 2015

Already merged in, closing.

@kinke kinke closed this Nov 22, 2015
@kinke kinke deleted the phobosMath branch August 24, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants