Add the @ldc.attributes.weak linkage attribute for global symbols. #1378
Conversation
JohanEngelen
changed the title
JohanEngelen
force-pushed
the
weaklink
branch
2 times, most recently
from
d426ece to
b91eeab
Compare
|
I am using this in Weka's LDC compiler to speed up a unittest build testcase by ~12%. edit: marking druntime functions as @weak and enabling https://github.com/D-Programming-Language/dmd/blob/master/src/root/rmem.d#L166-L193 |
tests/ir/lit.site.cfg.in
Outdated
| # subdirectories contain auxiliary inputs for various tests in their parent | ||
| # directories. | ||
| config.excludes = [] | ||
| config.excludes = ['Input'] |
There was a problem hiding this comment.
Shouldn't this be Inputs for consistency with LLVM (especially since the comment says so)? If we deviate from that, I would suggest going with a lower-case name to match the D conventions (input).
|
What you could do is to just have a |
I think I tried that, but then the logic has to be changed I think. (it's no longer a StructExpression) |
|
Either way works out fine. One might be a bit prettier, but the other is easier to implement. Your choice. ;) |
|
Well... one is already implemented.... ;) |
| return true; | ||
| } | ||
|
|
||
| bool isFromLdcAttibutes(const StructLiteralExp *e) { |
There was a problem hiding this comment.
Where is the new overload used?
There was a problem hiding this comment.
At the moment, it's not used anywhere but here. It was a refactoring to allow checking of other types of ldc.attributes. I kept it for future use convenience / easier reading of code.
There was a problem hiding this comment.
My critique would be that isFromLdcAttributes should really be isLdcAttributes for the ModuleDeclaration overload then, since the module is not "from" itself.
There was a problem hiding this comment.
Thanks, changing it.
|
Perhaps "for consistency" |
|
I prefer just having |
|
I've made |
|
The druntime change = ldc-developers/druntime@ldc-ltsmaster...weaklink |
|
Feel free to merge once this passes. |
|
@klickverbot Thanks for your comments. |
|
(recommitted to correctly trigger CI) |
2 participants
Implements #1376 .
I did not know how to best implement a UDA syntax
@weakwithout using astruct _weakandalias weak = _weak(). I thought@weak()would be ugly, but I have no strong opinion on this. Please advise on naming :)