Fix a regression in gc2stack optimization#4511
Merged
JohanEngelen merged 3 commits intoldc-developers:masterfrom Oct 11, 2023
Merged
Fix a regression in gc2stack optimization#4511JohanEngelen merged 3 commits intoldc-developers:masterfrom
JohanEngelen merged 3 commits intoldc-developers:masterfrom
Conversation
This fixes ldc-developers#4510. LLVM RAII helper did not fit in case, at ldc-developers@1d969cf.
| Builder.CreateAlloca(Ty, count, ".nongc_mem"); // FIXME: align? | ||
|
|
||
| if (Initialized) { | ||
| // For now, only zero-init is supported. |
Member
There was a problem hiding this comment.
can you improve the comment on line 190-191 to say that the initialization must be put at the original source variable definition location (explicit mention: because it could be in a loop).
Member
|
great, thanks for the fix + testcase. See my comments, mainly reducing the PR to what's needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4510.
LLVM RAII helper did not fit in case, at 1d969cf.