Remove extra load on assignment generated only for debug info #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to serious problems for values we really should not be loading from, such as 100k element static arrays. It was hard to figure out exactly why we need to emit DWARF info here, so the easiest solution is to just have a look at assignments during the next big debug info push.
redstar
added a commit
that referenced
this pull request
May 29, 2015
Remove extra load on assignment generated only for debug info
Member
|
During last debug session I noted that ldc sometimes generates unnecessary loads. E.g. storing a value and then loading it. I did not have a closer look. Maybe this is caused by this, too. |
Member
Author
|
These loads were strictly unused, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to serious problems for values we really should
not be loading from, such as 100k element static arrays.
It was hard to figure out exactly why we need to emit DWARF
info here, so the easiest solution is to just have a look
at assignments during the next big debug info push.
@liranz