Skip to content

Conversation

@dnadlinger
Copy link
Member

No description provided.

@dnadlinger
Copy link
Member Author

@redstar: This seems to be just about the only thing we can do for now, unless we want to try adding crazy workarounds to our IR gen. Any ideas?

@redstar
Copy link
Member

redstar commented Jun 8, 2015

The linker class is in a single file. We could include the fixed class and use it if we detect LLVM 3.6.

@dnadlinger
Copy link
Member Author

…unless somebody tries to use a shared library build of LLVM?

@dnadlinger
Copy link
Member Author

(My favourite option for now is just to get rid of Linker entirely and emit everything to the same module for -singleobj builds.)

@dnadlinger
Copy link
Member Author

Oh, you mean, we could just ship our own ldc::IRLinker instead? Yes, that would probably be the easiest fix. However, I'll still try to get rid of it entirely tomorrow. It's a big source of complexity I'd rather not have in the first place.

dnadlinger added a commit to dnadlinger/ldc that referenced this pull request Jun 14, 2015
dnadlinger added a commit to dnadlinger/ldc that referenced this pull request Jun 14, 2015
dnadlinger added a commit to dnadlinger/ldc that referenced this pull request Jun 14, 2015
dnadlinger added a commit to dnadlinger/ldc that referenced this pull request Jun 14, 2015
dnadlinger added a commit to dnadlinger/ldc that referenced this pull request Jun 14, 2015
dnadlinger added a commit to dnadlinger/ldc that referenced this pull request Jun 14, 2015
@dnadlinger
Copy link
Member Author

See #974 which removes the dependency on llvm::Linker (except for inline IR, where it is not problematic).

@dnadlinger dnadlinger closed this Jun 14, 2015
@dnadlinger dnadlinger deleted the disable-llvm36 branch June 14, 2015 19:56
@redstar
Copy link
Member

redstar commented Jun 18, 2015

Yes, I proposed to include the modified llvm::Linker class. But removing the dependency on llvm::Linker is another good solution. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants