Add modified version of LinkModules.cpp for LLVM 3.6. #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a serious bug in the linker code. See http://reviews.llvm.org/D10301 for the applied diff.
Closed
Member
|
This is not enough to completely fix the issue. Related linker bugs still occurred in a large codebase I'm working on (extracting a minimal testcase would be a week's amount of work). Please just backport my changes to master instead. |
Member
Author
|
Ok, I try it. |
Member
Author
|
See #985. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a serious bug in the linker code. See
http://reviews.llvm.org/D10301 for the applied diff.