Skip to content

build more accurate parse tree containing comment nodes#77

Merged
robocoder merged 1 commit intoleafo:masterfrom
robocoder:nested-format-comments
Aug 4, 2014
Merged

build more accurate parse tree containing comment nodes#77
robocoder merged 1 commit intoleafo:masterfrom
robocoder:nested-format-comments

Conversation

@robocoder
Copy link
Collaborator

@robocoder robocoder commented Mar 29, 2013

@robocoder
Copy link
Collaborator Author

robocoder commented May 17, 2013

Not compatible with this commit leafo/lessphp@8991b3e

@robocoder robocoder mentioned this pull request Sep 21, 2013
Closed
@robocoder
Copy link
Collaborator Author

robocoder commented Jul 8, 2014

This has been merged to the "develop" branch. Two problems remaining:

  • the first comment in the first class is raised to the root level of the parse tree
  • some comments are misaligned; I believe the wrong $inner value is passed to blockLines()

@robocoder robocoder mentioned this pull request Jul 8, 2014
Closed
robocoder added a commit that referenced this pull request Aug 4, 2014
@robocoder
fixes #77
66ff686
@robocoder robocoder merged commit 97f62d2 into leafo:master Aug 4, 2014
@robocoder robocoder deleted the nested-format-comments branch August 7, 2014 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@robocoder