Validate Tailscale login URL scheme - #219
Merged
yuri91 merged 2 commits intoMay 7, 2026
Merged
Conversation
Signed-off-by: Nadav0077 <18245584+Nadav0077@users.noreply.github.com>
Signed-off-by: Nadav0077 <18245584+Nadav0077@users.noreply.github.com>
yuri91
approved these changes
May 7, 2026
yuri91
left a comment
yuri91
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thank you for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the custom Tailscale/Headscale login flow so returned auth URLs must be normal http(s) URLs before WebVM navigates the login popup to them.
A malicious custom control server should not be able to return a scriptable URL such as javascript: and have it execute in the WebVM origin.
validation happens when the login URL is received, before it reaches either the popup navigation or the sidebar link. If validation fails, the login popup is closed and the UI shows an invalid login URL state.
I validated this locally: