Skip to content

[Merged by Bors] - feat: IsometryClass#18754

Closed
astrainfinita wants to merge 2 commits intomasterfrom
FR_isometryclass
Closed

[Merged by Bors] - feat: IsometryClass#18754
astrainfinita wants to merge 2 commits intomasterfrom
FR_isometryclass

Conversation

@astrainfinita
Copy link
Collaborator

@astrainfinita astrainfinita added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Nov 8, 2024
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

PR summary 0f6df6bbfa

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsometryClass
+ antilipschitz
+ coe_coe
+ continuous
+ diam_image
+ diam_range
+ dist_eq
+ ediam_image
+ ediam_range
+ edist_eq
+ instance : CoeOut F (α ≃ᵢ β)
+ instance : IsometryClass (IsometryEquiv α β) α β
+ lipschitz
+ nndist_eq
+ nnnorm_map'
+ norm_map'
+ toContinuousMapClass
+ toHomeomorphClass
+ toIsometryEquiv
+ toIsometryEquiv_injective

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
4876 2 exceptions for the docPrime linter

Current commit 0f6df6bbfa
Reference commit 7a4b93882b

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 8, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 15, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 16, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 21, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jan 14, 2025
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a coercion to IsometryEquiv along with the standard simp lemmas for it?

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 21, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 11, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 2, 2025
@astrainfinita astrainfinita added t-analysis Analysis (normed *, calculus) and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Apr 2, 2025
@j-loreaux
Copy link
Collaborator

Thanks! This looks good.

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label May 9, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 9, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 9, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: IsometryClass [Merged by Bors] - feat: IsometryClass May 9, 2025
@mathlib-bors mathlib-bors bot closed this May 9, 2025
@mathlib-bors mathlib-bors bot deleted the FR_isometryclass branch May 9, 2025 20:11
tannerduve pushed a commit that referenced this pull request May 13, 2025
bwehlin pushed a commit to bwehlin/mathlib4 that referenced this pull request May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus) t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants