Skip to content

[Merged by Bors] - feat(MvPolynomial): multiplicativity of totalDegree over domains#24347

Closed
erdOne wants to merge 3 commits intomasterfrom
erd1/totalDegree_mul
Closed

[Merged by Bors] - feat(MvPolynomial): multiplicativity of totalDegree over domains#24347
erdOne wants to merge 3 commits intomasterfrom
erd1/totalDegree_mul

Conversation

@erdOne
Copy link
Member

@erdOne erdOne commented Apr 24, 2025


Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 24, 2025
@github-actions
Copy link

github-actions bot commented Apr 24, 2025

PR summary b814af2026

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ degree_mem_support
+ totalDegree_mul_of_isDomain

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@erdOne erdOne added the t-algebra Algebra (groups, rings, fields, etc) label Apr 24, 2025
@erdOne erdOne added the WIP Work in progress label Apr 24, 2025
@erdOne erdOne force-pushed the erd1/totalDegree_mul branch from 76e19d9 to 26a429d Compare April 24, 2025 22:14
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Apr 24, 2025
@erdOne erdOne removed the WIP Work in progress label Apr 25, 2025
Copy link
Collaborator

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link

github-actions bot commented May 4, 2025

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 4, 2025
@adomani
Copy link
Collaborator

adomani commented May 4, 2025

This looks good to me, thanks!

I wonder whether this could be generalized further using machinery similar to UniqueSums: I remember that there arbitrary linear orders in the univariate case were later replaced by UniqueSums. This can wait for a later PR, though.

I'll ping @alreadydone as well, in case this piques his interest as well!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 4, 2025

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 4, 2025
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not sure how you'd define a degree without a total order ...

@adomani
Copy link
Collaborator

adomani commented May 5, 2025

I meant more that, in the presence of a linear order, there is a UniqueSums on the grading monoid and you can probably prove multiplicativity with a UniqueSums assumption on the grading monoid.

Anyway, this discussion is not really for the current PR!

@erdOne, feel free to make the suggested change and merge!

@erdOne
Copy link
Member Author

erdOne commented May 5, 2025

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 5, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(MvPolynomial): multiplicativity of totalDegree over domains [Merged by Bors] - feat(MvPolynomial): multiplicativity of totalDegree over domains May 5, 2025
@mathlib-bors mathlib-bors bot closed this May 5, 2025
@mathlib-bors mathlib-bors bot deleted the erd1/totalDegree_mul branch May 5, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants