Skip to content

[Merged by Bors] - chore: remove inlined lake-build-with-retry.sh from workflow, improve log messages#28016

Closed
bryangingechen wants to merge 2 commits into
leanprover-community:masterfrom
bryangingechen:remove_lake-build-with-retry_from_workflow
Closed

[Merged by Bors] - chore: remove inlined lake-build-with-retry.sh from workflow, improve log messages#28016
bryangingechen wants to merge 2 commits into
leanprover-community:masterfrom
bryangingechen:remove_lake-build-with-retry_from_workflow

Conversation

@bryangingechen
Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen commented Aug 5, 2025

To merge #27691, I had to inline a copy of lake-build-with-retry.sh into the workflow file (since the workflow always tries to run the master branch version of scripts, etc.). Now that that file exists in the master branch, we can remove this code.

I also improved the log messages for the step checking if the archive + counterexamples builds failed.


Open in Gitpod

@bryangingechen bryangingechen added easy < 20s of review time. See the lifecycle page for guidelines. CI Modifies the continuous integration setup or other automation labels Aug 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 5, 2025

PR summary f95517183c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@bryangingechen bryangingechen changed the title chore: remove inlined lake-build-with-retry.sh from workflow chore: remove inlined lake-build-with-retry.sh from workflow, improve log messages Aug 7, 2025
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Aug 7, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Aug 7, 2025
mathlib-bors Bot pushed a commit that referenced this pull request Aug 7, 2025
… log messages (#28016)

To merge #27691, I had to inline a copy of  `lake-build-with-retry.sh` into the workflow file (since the workflow always tries to run the `master` branch version of scripts, etc.). Now that that file  exists in the `master` branch, we can remove this code.

I also improved the log messages for the step checking if the archive + counterexamples builds failed.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Aug 7, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: remove inlined lake-build-with-retry.sh from workflow, improve log messages [Merged by Bors] - chore: remove inlined lake-build-with-retry.sh from workflow, improve log messages Aug 7, 2025
@mathlib-bors mathlib-bors Bot closed this Aug 7, 2025
staroperator pushed a commit to staroperator/mathlib4 that referenced this pull request Aug 8, 2025
… log messages (leanprover-community#28016)

To merge leanprover-community#27691, I had to inline a copy of  `lake-build-with-retry.sh` into the workflow file (since the workflow always tries to run the `master` branch version of scripts, etc.). Now that that file  exists in the `master` branch, we can remove this code.

I also improved the log messages for the step checking if the archive + counterexamples builds failed.
@alreadydone
Copy link
Copy Markdown
Contributor

A question maybe unrelated to this PR but people here probably know the answer: I don't know since when but currently the build logs are removed after builds are completed (even though you get rolling updates when building). In this run the "Check if building Archive or Counterexamples failed" step failed, but I can't see where it fails. Note that Mathlib build errors are replayed in the "lint mathlib" step, but Archive and Counterexamples build errors aren't replayed. Isn't it better to keep the Archive and Counterexamples build logs given the situation?

Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
… log messages (leanprover-community#28016)

To merge leanprover-community#27691, I had to inline a copy of  `lake-build-with-retry.sh` into the workflow file (since the workflow always tries to run the `master` branch version of scripts, etc.). Now that that file  exists in the `master` branch, we can remove this code.

I also improved the log messages for the step checking if the archive + counterexamples builds failed.
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
… log messages (leanprover-community#28016)

To merge leanprover-community#27691, I had to inline a copy of  `lake-build-with-retry.sh` into the workflow file (since the workflow always tries to run the `master` branch version of scripts, etc.). Now that that file  exists in the `master` branch, we can remove this code.

I also improved the log messages for the step checking if the archive + counterexamples builds failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants