[Merged by Bors] - chore: remove inlined lake-build-with-retry.sh from workflow, improve log messages#28016
Conversation
PR summary f95517183cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
bors merge |
… log messages (#28016) To merge #27691, I had to inline a copy of `lake-build-with-retry.sh` into the workflow file (since the workflow always tries to run the `master` branch version of scripts, etc.). Now that that file exists in the `master` branch, we can remove this code. I also improved the log messages for the step checking if the archive + counterexamples builds failed.
|
Pull request successfully merged into master. Build succeeded: |
… log messages (leanprover-community#28016) To merge leanprover-community#27691, I had to inline a copy of `lake-build-with-retry.sh` into the workflow file (since the workflow always tries to run the `master` branch version of scripts, etc.). Now that that file exists in the `master` branch, we can remove this code. I also improved the log messages for the step checking if the archive + counterexamples builds failed.
|
A question maybe unrelated to this PR but people here probably know the answer: I don't know since when but currently the build logs are removed after builds are completed (even though you get rolling updates when building). In this run the "Check if building Archive or Counterexamples failed" step failed, but I can't see where it fails. Note that Mathlib build errors are replayed in the "lint mathlib" step, but Archive and Counterexamples build errors aren't replayed. Isn't it better to keep the Archive and Counterexamples build logs given the situation? |
… log messages (leanprover-community#28016) To merge leanprover-community#27691, I had to inline a copy of `lake-build-with-retry.sh` into the workflow file (since the workflow always tries to run the `master` branch version of scripts, etc.). Now that that file exists in the `master` branch, we can remove this code. I also improved the log messages for the step checking if the archive + counterexamples builds failed.
… log messages (leanprover-community#28016) To merge leanprover-community#27691, I had to inline a copy of `lake-build-with-retry.sh` into the workflow file (since the workflow always tries to run the `master` branch version of scripts, etc.). Now that that file exists in the `master` branch, we can remove this code. I also improved the log messages for the step checking if the archive + counterexamples builds failed.
To merge #27691, I had to inline a copy of
lake-build-with-retry.shinto the workflow file (since the workflow always tries to run themasterbranch version of scripts, etc.). Now that that file exists in themasterbranch, we can remove this code.I also improved the log messages for the step checking if the archive + counterexamples builds failed.