[Merged by Bors] - feat(MeasureTheory): add Star, InvolutiveStar, and TrivialStar instances for Lp#28410
Closed
JonBannon wants to merge 38 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(MeasureTheory): add Star, InvolutiveStar, and TrivialStar instances for Lp#28410JonBannon wants to merge 38 commits intoleanprover-community:masterfrom
Star, InvolutiveStar, and TrivialStar instances for Lp#28410JonBannon wants to merge 38 commits intoleanprover-community:masterfrom
Conversation
…porting API for `StronglyMeasurable` functions.
…Type*} [Star R] {f g : α → R} {l : Filter α}
(h : f =ᶠ[l] g) : (fun x ↦ star (f x)) =ᶠ[l] fun x ↦ star (g x) :=
h.fun_comp Star.star.
If I put this in Mathlib.Order.Filter.Basic we get import collisions with other files. (Probably some kind of circular import.) But where to put it?
… sort where it can go.
… work, so rolling it back for now.
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…(and removed the unnecessary _root_.Filter. from each)
PR summary 3b097993a0Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
…om recent PR regarding AEEqFun
ADedecker
reviewed
Aug 23, 2025
j-loreaux
reviewed
Aug 26, 2025
j-loreaux
reviewed
Aug 28, 2025
Collaborator
Author
|
Oh man. Super slick.
…On Thu, Aug 28, 2025, 10:48 AM Jireh Loreaux ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Mathlib/MeasureTheory/Function/LpSpace/Basic.lean
<#28410 (comment)>
:
> +noncomputable instance {p : ℝ≥0∞} : InvolutiveStar (Lp R p μ) where
+ star_involutive f := by
+ ext
+ filter_upwards
+ exact congrFun (congrArg AEEqFun.cast <| star_involutive f.1)
+
+noncomputable instance [TrivialStar R] {p : ℝ≥0∞} : TrivialStar (Lp R p μ) where
+ star_trivial f := by
+ ext
+ filter_upwards
+ exact congrFun (congrArg AEEqFun.cast <| star_trivial f.1)
Here's the right approach:
⬇️ Suggested change
-noncomputable instance {p : ℝ≥0∞} : InvolutiveStar (Lp R p μ) where
- star_involutive f := by
- ext
- filter_upwards
- exact congrFun (congrArg AEEqFun.cast <| star_involutive f.1)
-
-noncomputable instance [TrivialStar R] {p : ℝ≥0∞} : TrivialStar (Lp R p μ) where
- star_trivial f := by
- ext
- filter_upwards
- exact congrFun (congrArg AEEqFun.cast <| star_trivial f.1)
+noncomputable instance {p : ℝ≥0∞} : InvolutiveStar (Lp R p μ) where
+ star_involutive _ := Subtype.ext <| star_involutive _
+
+noncomputable instance [TrivialStar R] {p : ℝ≥0∞} : TrivialStar (Lp R p μ) where
+ star_trivial _ := Subtype.ext <| star_trivial _
What I was originally suggesting was this:
noncomputable instance {p : ℝ≥0∞} : InvolutiveStar (Lp R p μ) where
star_involutive f := by
ext
filter_upwards with x
congrm($(star_involutive f.1) x)
noncomputable instance [TrivialStar R] {p : ℝ≥0∞} : TrivialStar (Lp R p μ) where
star_trivial f := by
ext
filter_upwards with x
congrm($(star_trivial f.1) x)
—
Reply to this email directly, view it on GitHub
<#28410 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJJJTRMNCXRC7WTVNVSY233P4JC5AVCNFSM6AAAAACD5FKFNWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCNRVGIYTEMJVGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
…instances for `Lp` (#28410) This PR introduces the three above instances, aiming toward a `CStarAlgebra` instance for `Linfty`. Co-authored-by: Jon Bannon <jbannon@siena.edu>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Star, InvolutiveStar, and TrivialStar instances for LpStar, InvolutiveStar, and TrivialStar instances for Lp
FormulaRabbit81
pushed a commit
to YaelDillies/mathlib4
that referenced
this pull request
Aug 30, 2025
…instances for `Lp` (leanprover-community#28410) This PR introduces the three above instances, aiming toward a `CStarAlgebra` instance for `Linfty`. Co-authored-by: Jon Bannon <jbannon@siena.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the three above instances, aiming toward a
CStarAlgebrainstance forLinfty.