[Merged by Bors] - feat: if 1 < x then y ^ n < x for some 1 < y#28942
Closed
vihdzp wants to merge 6 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat: if 1 < x then y ^ n < x for some 1 < y#28942vihdzp wants to merge 6 commits intoleanprover-community:masterfrom
1 < x then y ^ n < x for some 1 < y#28942vihdzp wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
vihdzp
added
awaiting-CI
github-actions
bot
added
the
large-import
PR summary b69b8b678eImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Group.DenselyOrdered | 222 | 229 | +7 (+3.15%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Order.Group.DenselyOrdered |
7 |
Declarations diff
+ exists_lt_pow_of_lt_one
+ exists_pow_lt_of_one_lt
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
github-actions
bot
removed
the
awaiting-CI
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
YaelDillies
reviewed
Aug 31, 2025
Contributor
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
Can you multiplicativise everything?
YaelDillies
added
the
awaiting-author
vihdzp
removed
the
awaiting-author
YaelDillies
approved these changes
Aug 31, 2025
Contributor
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
ghost
added
the
maintainer-merge
Contributor
|
Thanks! Could you update the PR title, now that the results are multiplicativised and bors d+ |
Contributor
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
vihdzp
changed the title
0 < x then n • y < x for some y1 < x then 1 < y^n < x for some y
vihdzp
changed the title
1 < x then 1 < y^n < x for some y1 < x then y ^ n < x for some 1 < y
Collaborator
Author
|
bors r+ |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
1 < x then y ^ n < x for some 1 < y1 < x then y ^ n < x for some 1 < y
CBirkbeck
pushed a commit
to CBirkbeck/mathlib4
that referenced
this pull request
Sep 8, 2025
…ity#28942) Co-authored-by: Yaël Dillies <yael.dillies@gmail.com> Co-authored-by: Author Name <yael.dillies@gmail.com>
yuanyi-350
pushed a commit
to yuanyi-350/yuanyi_mathlib4
that referenced
this pull request
Sep 10, 2025
…ity#28942) Co-authored-by: Yaël Dillies <yael.dillies@gmail.com> Co-authored-by: Author Name <yael.dillies@gmail.com>
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Oct 2, 2025
…ity#28942) Co-authored-by: Yaël Dillies <yael.dillies@gmail.com> Co-authored-by: Author Name <yael.dillies@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Yaël Dillies yael.dillies@gmail.com