feat(Geometry/Convex/Cone): linear span of conic span of set equals linear span of set#32471
feat(Geometry/Convex/Cone): linear span of conic span of set equals linear span of set#32471bjornsolheim wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary e43846c17cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
| Submodule.span R (PointedCone.span R s : Set E) = Submodule.span R s := by | ||
| letI : SMul R≥0 R := ⟨fun ⟨c, _⟩ r => c * r⟩ | ||
| letI : IsScalarTower R≥0 R E := ⟨fun ⟨c, _⟩ r m => mul_smul c r m⟩ | ||
| exact Submodule.span_span_of_tower R≥0 R s |
There was a problem hiding this comment.
Both of these exist as instances. You can check this by writing:
#synth SMul R≥0 R
#synth IsScalarTower R≥0 R Ejust above the lemma and Lean will provide clickable link to the instance or you can just delete them and observe as follows:
| Submodule.span R (PointedCone.span R s : Set E) = Submodule.span R s := by | |
| letI : SMul R≥0 R := ⟨fun ⟨c, _⟩ r => c * r⟩ | |
| letI : IsScalarTower R≥0 R E := ⟨fun ⟨c, _⟩ r m => mul_smul c r m⟩ | |
| exact Submodule.span_span_of_tower R≥0 R s | |
| Submodule.span R (PointedCone.span R s : Set E) = Submodule.span R s := | |
| Submodule.span_span_of_tower R≥0 R s |
Given the above, as well as the fact that PointedCone.span is already an abbrev I don't think we should introduce this lemma, since it is just an alias for Submodule.span_span_of_tower.
ocfnash
left a comment
There was a problem hiding this comment.
Thanks for your work. Unfortunately I'm going to close this PR since the proposed lemmas ends up just being an alias for Submodule.span_span_of_tower.
|
Of course. This was on me. Thank you for explaining the reasoning and relevant techniques. |
Submodule.span_span_of_towerto pointed cones.