[Merged by Bors] - doc(RingTheory/Polynomial/GaussNorm): add sentence about heights of polynomials#33338
Closed
fbarroero wants to merge 1 commit intoleanprover-community:masterfrom
Closed
Conversation
Collaborator
fbarroero
commented
Dec 27, 2025
PR summary 31b5cb4bf4Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Pull request overview
This PR adds documentation to clarify the connection between the Gauss norm and the concept of polynomial heights in algebraic number theory.
- Explains that the Gauss norm is most useful when
vis an absolute value andc = 1 - Notes that when
Ris a subring ofℂwith standard absolute value, this is called the "height" of the polynomial
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 28, 2025
…olynomials (#33338) Co-authored-by: fbarroero <fbarroero@gmail.com>
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 28, 2025
…olynomials (#33338) Co-authored-by: fbarroero <fbarroero@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
kim-em
pushed a commit
to kim-em/mathlib4
that referenced
this pull request
Jan 6, 2026
…olynomials (leanprover-community#33338) Co-authored-by: fbarroero <fbarroero@gmail.com>
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
…olynomials (leanprover-community#33338) Co-authored-by: fbarroero <fbarroero@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.