Skip to content

[Merged by Bors] - doc(RingTheory/Polynomial/GaussNorm): add sentence about heights of polynomials#33338

Closed
fbarroero wants to merge 1 commit intoleanprover-community:masterfrom
fbarroero:fbarroero_GaussNorm_doc
Closed

[Merged by Bors] - doc(RingTheory/Polynomial/GaussNorm): add sentence about heights of polynomials#33338
fbarroero wants to merge 1 commit intoleanprover-community:masterfrom
fbarroero:fbarroero_GaussNorm_doc

Conversation

@fbarroero
Copy link
Collaborator


Open in Gitpod

@fbarroero fbarroero added the easy < 20s of review time. See the lifecycle page for guidelines. label Dec 27, 2025
@github-actions github-actions bot added the t-ring-theory Ring theory label Dec 27, 2025
@github-actions
Copy link

PR summary 31b5cb4bf4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation to clarify the connection between the Gauss norm and the concept of polynomial heights in algebraic number theory.

  • Explains that the Gauss norm is most useful when v is an absolute value and c = 1
  • Notes that when R is a subring of with standard absolute value, this is called the "height" of the polynomial

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erdOne
Copy link
Member

erdOne commented Dec 27, 2025

Thanks!
maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 27, 2025
@vihdzp vihdzp added the documentation Improvements or additions to documentation label Dec 27, 2025
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 28, 2025
…olynomials (#33338)

Co-authored-by: fbarroero <fbarroero@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 28, 2025

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Dec 28, 2025
…olynomials (#33338)

Co-authored-by: fbarroero <fbarroero@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 28, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(RingTheory/Polynomial/GaussNorm): add sentence about heights of polynomials [Merged by Bors] - doc(RingTheory/Polynomial/GaussNorm): add sentence about heights of polynomials Dec 28, 2025
@mathlib-bors mathlib-bors bot closed this Dec 28, 2025
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants