Skip to content

Conversation

@JovanGerb
Copy link
Collaborator

This comment in the code complains about a limitation of @[reassoc], but it seems reassoc has improved since.


Open in Gitpod

@github-actions
Copy link

PR summary 953704ae86

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- hom_inv_id_assoc
- inv_hom_id_assoc

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-category-theory Category theory label Jan 14, 2026
@joelriou
Copy link
Collaborator

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 14, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 14, 2026
This comment in the code complains about a limitation of `@[reassoc]`, but it seems `reassoc` has improved since.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory/Iso): address FIXME [Merged by Bors] - chore(CategoryTheory/Iso): address FIXME Jan 14, 2026
@mathlib-bors mathlib-bors bot closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants