-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(GroupTheory/FinitelyPresentedGroup): add finitely presented groups #34236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
homeowmorphism
wants to merge
109
commits into
leanprover-community:master
Choose a base branch
from
homeowmorphism:FinitelyPresentedGroup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(GroupTheory/FinitelyPresentedGroup): add finitely presented groups #34236
homeowmorphism
wants to merge
109
commits into
leanprover-community:master
from
homeowmorphism:FinitelyPresentedGroup
+476
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add equivalence lemmas (incomplete) - Add basic instances (incomplete) Working on: isFinitelyPresented_iff_finite_set forward direction
- Add equivalence lemmas (incomplete) - Add basic instances (incomplete) Working on: isFinitelyPresented_iff_finite_set forward direction
…NormalClosureOfFiniteSet f'.ker`. Draft until I can figure out cleaner ways to do it.
…s more descriptive for groups.
…er_comp_mulEquiv` lemma.
…f (wip) and recovered instance
…stead of `α : Type`.
…ntedGroup G` draft human pf
Co-authored-by: Laurance Lau <60111599+LLaurance@users.noreply.github.com>
… `freeGroupUnitMulEquivInt`
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
…ith an isomorphism (#34580) feat(Algebra/Group/Subgroup/Ker): kernel of a homomorphism composed with an isomorphism The kernel of a homomorphism composed with an isomorphism is equal to the kernel of the homomorphism mapped by the inverse isomorphism. This is a dependency of a larger PR to formalize finitely presented groups #34236.
|
This pull request has conflicts, please merge |
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Feb 3, 2026
…ith an isomorphism (leanprover-community#34580) feat(Algebra/Group/Subgroup/Ker): kernel of a homomorphism composed with an isomorphism The kernel of a homomorphism composed with an isomorphism is equal to the kernel of the homomorphism mapped by the inverse isomorphism. This is a dependency of a larger PR to formalize finitely presented groups leanprover-community#34236.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
new-contributor
This PR was made by a contributor with at most 5 merged PRs. Welcome to the community!
t-group-theory
Group theory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formulation of finitely presented groups
feat(GroupTheory/FinitelyPresentedGroup): add finitely presented groups
We define the notion of
IsPresentedandIsFinitelyPresentedwith equivalent datatype notions, what it means for a subgroup to be finitely generated in the normal closure, and some instances of finitely presented groups.This started as an ItaLean2025 project. The related Zulip thread is here: https://leanprover.zulipchat.com/#narrow/channel/541885-ItaLean-2025/topic/Projects.3A.20Finitely.20Presented.20Groups/with/567565752.
Use of AI: Aristotle was used for giving a preliminary proof of some statements as this is my first contribution and I wanted to understand how to prove things; they have since been changed. ChatGPT was used to generate some of the proof sub-statements for efficiency once the mathematical blueprints of the proofs have been worked out.