[Merged by Bors] - fix(CI): run leanchecker in mathlib4 repo for both master and nightly#34480
Closed
[Merged by Bors] - fix(CI): run leanchecker in mathlib4 repo for both master and nightly#34480
Conversation
The leanchecker job was configured to run in mathlib4-nightly-testing but the notification job runs in mathlib4, causing the notification to fail to find the job and produce broken Zulip messages with empty URLs. This PR: - Moves check-leanchecker to run in mathlib4 (like the other check jobs) - Enables both master and nightly branches for leanchecker 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PR summary 0e16bffea0Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
…#34480) This PR fixes the daily CI workflow for leanchecker. The `check-leanchecker` job was configured to run only in `mathlib4-nightly-testing`, but the `notify-leanchecker` job runs in `mathlib4` and tries to query the job status from the current workflow run. Since the job was skipped in `mathlib4`, the notification produced broken Zulip messages with empty URLs (see https://leanprover.zulipchat.com/#narrow/channel/428973-nightly-testing/topic/leanchecker.20failure/near/570212817). This PR: - Moves `check-leanchecker` to run in `mathlib4` (matching `check-nanoda` and `check-mathlib_test_executable`) - Enables both `master` and `nightly` branches for leanchecker (the TODO comment indicated this was waiting for leanchecker to land on master) 🤖 Prepared with Claude Code
Contributor
|
Pull request successfully merged into master. Build succeeded: |
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Feb 3, 2026
…leanprover-community#34480) This PR fixes the daily CI workflow for leanchecker. The `check-leanchecker` job was configured to run only in `mathlib4-nightly-testing`, but the `notify-leanchecker` job runs in `mathlib4` and tries to query the job status from the current workflow run. Since the job was skipped in `mathlib4`, the notification produced broken Zulip messages with empty URLs (see https://leanprover.zulipchat.com/#narrow/channel/428973-nightly-testing/topic/leanchecker.20failure/near/570212817). This PR: - Moves `check-leanchecker` to run in `mathlib4` (matching `check-nanoda` and `check-mathlib_test_executable`) - Enables both `master` and `nightly` branches for leanchecker (the TODO comment indicated this was waiting for leanchecker to land on master) 🤖 Prepared with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the daily CI workflow for leanchecker.
The
check-leancheckerjob was configured to run only inmathlib4-nightly-testing, but thenotify-leancheckerjob runs inmathlib4and tries to query the job status from the current workflow run. Since the job was skipped inmathlib4, the notification produced broken Zulip messages with empty URLs (see https://leanprover.zulipchat.com/#narrow/channel/428973-nightly-testing/topic/leanchecker.20failure/near/570212817).This PR:
check-leancheckerto run inmathlib4(matchingcheck-nanodaandcheck-mathlib_test_executable)masterandnightlybranches for leanchecker (the TODO comment indicated this was waiting for leanchecker to land on master)🤖 Prepared with Claude Code