Skip to content

[Merged by Bors] - chore: simplify simp/grind patterns as suggested by linter#34714

Closed
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em:grind-linter-simplifications
Closed

[Merged by Bors] - chore: simplify simp/grind patterns as suggested by linter#34714
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em:grind-linter-simplifications

Conversation

@kim-em
Copy link
Contributor

@kim-em kim-em commented Feb 2, 2026

This PR removes redundant simp, simp only, and have statements before grind where grind can handle the goal directly, as suggested by the grind linter in the nightly testing run.

Addresses 6 of the 14 warnings from https://github.com/leanprover-community/mathlib4/actions/runs/21578471064

Zulip thread: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Weekly.20linting.20log/near/571353143

The remaining warnings involve cases where the preprocessing step (norm_cast, ext, convert_to, etc.) is actually necessary for grind to succeed.

🤖 Prepared with Claude Code

Remove redundant `simp`, `simp only`, and `have` statements before `grind`
where grind can handle the goal directly.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

PR summary 20310f506a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 2, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 2, 2026
This PR removes redundant `simp`, `simp only`, and `have` statements before `grind` where grind can handle the goal directly, as suggested by the grind linter in the nightly testing run.

Addresses 6 of the 14 warnings from https://github.com/leanprover-community/mathlib4/actions/runs/21578471064

Zulip thread: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Weekly.20linting.20log/near/571353143

The remaining warnings involve cases where the preprocessing step (`norm_cast`, `ext`, `convert_to`, etc.) is actually necessary for grind to succeed.

🤖 Prepared with Claude Code
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 2, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: simplify simp/grind patterns as suggested by linter [Merged by Bors] - chore: simplify simp/grind patterns as suggested by linter Feb 2, 2026
@mathlib-bors mathlib-bors bot closed this Feb 2, 2026
YellPika pushed a commit to YellPika/mathlib4 that referenced this pull request Feb 3, 2026
…r-community#34714)

This PR removes redundant `simp`, `simp only`, and `have` statements before `grind` where grind can handle the goal directly, as suggested by the grind linter in the nightly testing run.

Addresses 6 of the 14 warnings from https://github.com/leanprover-community/mathlib4/actions/runs/21578471064

Zulip thread: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Weekly.20linting.20log/near/571353143

The remaining warnings involve cases where the preprocessing step (`norm_cast`, `ext`, `convert_to`, etc.) is actually necessary for grind to succeed.

🤖 Prepared with Claude Code
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Feb 15, 2026
…r-community#34714)

This PR removes redundant `simp`, `simp only`, and `have` statements before `grind` where grind can handle the goal directly, as suggested by the grind linter in the nightly testing run.

Addresses 6 of the 14 warnings from https://github.com/leanprover-community/mathlib4/actions/runs/21578471064

Zulip thread: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Weekly.20linting.20log/near/571353143

The remaining warnings involve cases where the preprocessing step (`norm_cast`, `ext`, `convert_to`, etc.) is actually necessary for grind to succeed.

🤖 Prepared with Claude Code
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
…r-community#34714)

This PR removes redundant `simp`, `simp only`, and `have` statements before `grind` where grind can handle the goal directly, as suggested by the grind linter in the nightly testing run.

Addresses 6 of the 14 warnings from https://github.com/leanprover-community/mathlib4/actions/runs/21578471064

Zulip thread: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Weekly.20linting.20log/near/571353143

The remaining warnings involve cases where the preprocessing step (`norm_cast`, `ext`, `convert_to`, etc.) is actually necessary for grind to succeed.

🤖 Prepared with Claude Code
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
…r-community#34714)

This PR removes redundant `simp`, `simp only`, and `have` statements before `grind` where grind can handle the goal directly, as suggested by the grind linter in the nightly testing run.

Addresses 6 of the 14 warnings from https://github.com/leanprover-community/mathlib4/actions/runs/21578471064

Zulip thread: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Weekly.20linting.20log/near/571353143

The remaining warnings involve cases where the preprocessing step (`norm_cast`, `ext`, `convert_to`, etc.) is actually necessary for grind to succeed.

🤖 Prepared with Claude Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants