Skip to content

[Merged by Bors] - chore(Nat/Fib/Basic): fix names and csimp#34810

Closed
astrainfinita wants to merge 1 commit intoleanprover-community:masterfrom
astrainfinita:fastfib
Closed

[Merged by Bors] - chore(Nat/Fib/Basic): fix names and csimp#34810
astrainfinita wants to merge 1 commit intoleanprover-community:masterfrom
astrainfinita:fastfib

Conversation

@astrainfinita
Copy link
Collaborator

@astrainfinita astrainfinita commented Feb 3, 2026

and add a csimp lemma to connect the existing Nat.fastFib.


Open in Gitpod

and add a `csimp` lemma.
@astrainfinita astrainfinita added easy < 20s of review time. See the lifecycle page for guidelines. t-data Data (lists, quotients, numbers, etc) labels Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

PR summary 9493b30b5d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ fastFibAux_bit_false
+ fastFibAux_bit_true
+ fastFibAux_eq
+ fastFib_eq
+ fib_eq_fastFib

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser eric-wieser changed the title chore(Nat/Fib/Basic): fix names chore(Nat/Fib/Basic): fix names and csimp Feb 4, 2026
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

As a follow-up, perhaps we should make all the fastFib results private? That's perhaps a question for Zulip, and certainly a problem for another PR.

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 4, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 4, 2026
and add a `csimp` lemma to connect the existing `Nat.fastFib`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 4, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Nat/Fib/Basic): fix names and csimp [Merged by Bors] - chore(Nat/Fib/Basic): fix names and csimp Feb 4, 2026
@mathlib-bors mathlib-bors bot closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants