Skip to content

Conversation

@urkud
Copy link
Member

@urkud urkud commented Feb 5, 2026

urkud added 3 commits February 4, 2026 02:34
- Generalize some lemmas to the TVS setting.
- Use `Topology.IsInducing` instead of `AntilipschitzWith` or `ContinuousLinearEquiv`.
@urkud urkud requested a review from eric-wieser February 5, 2026 06:25
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

PR summary b7a1849720

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 5, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 5, 2026
@mathlib-dependent-issues
Copy link

This PR/issue depends on:

@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 5, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 5, 2026
@urkud
Copy link
Member Author

urkud commented Feb 5, 2026

!bench

@leanprover-radar
Copy link

leanprover-radar commented Feb 5, 2026

Benchmark results for e9eab3e against b7a1849 are in! @urkud

  • 🟥 build//instructions: +59.2G (+0.03%)

Large changes (1✅)

  • build/module/Mathlib.Analysis.Calculus.FDeriv.ContinuousAlternatingMap//instructions: -51.1G (-31.43%)

Medium changes (4🟥)

  • 🟥 build/module/Mathlib.Analysis.Calculus.ContDiff.RestrictScalars//instructions: +1.7G (+7.01%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.Deriv.Abs//instructions: +2.6G (+9.55%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.ContinuousMultilinearMap//instructions: +10.2G (+8.73%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.WithLp//instructions: +1.6G (+8.35%)

Small changes (1✅, 15🟥)

  • 🟥 build/module/Mathlib.Analysis.Calculus.ContDiff.Basic//instructions: +6.4G (+6.14%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.ContDiff.Convolution//instructions: +2.1G (+1.99%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.ContDiff.Operations//instructions: +4.3G (+2.66%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.DifferentialForm.Basic//instructions: +1.2G (+2.37%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.Analytic//instructions: +6.8G (+3.30%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.Comp//instructions: +12.2G (+36.20%) (reduced significance based on *//lines)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.CompCLM//instructions: +7.6G (+5.99%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.Equiv//instructions: +4.2G (+4.80%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.Mul//instructions: +5.5G (+2.60%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.Pi//instructions: +581.1M (+4.98%)
  • 🟥 build/module/Mathlib.Analysis.Calculus.FDeriv.Prod//instructions: +6.7G (+6.28%)
  • 🟥 build/module/Mathlib.Analysis.Complex.Harmonic.Analytic//instructions: +641.8M (+2.36%)
  • 🟥 build/module/Mathlib.Analysis.Complex.Schwarz//instructions: +1.3G (+4.18%)
  • 🟥 build/module/Mathlib.Analysis.InnerProductSpace.Calculus//instructions: +3.4G (+5.51%)
  • 🟥 build/module/Mathlib.Geometry.Manifold.ContMDiffMFDeriv//instructions: +1.7G (+3.02%)
  • build/module/Mathlib.RingTheory.Complex//instructions: -343.9M (-3.99%)

@urkud
Copy link
Member Author

urkud commented Feb 5, 2026

@eric-wieser This looks like a larger slowdown. Any ideas on how can we speed it up?

@eric-wieser
Copy link
Member

Generalizing many downstream files too would help with that performance loss; perhaps you should start stacking PRs for the sake of benchmarking a slightly-more-complete refactor?

Comment on lines +191 to +192
x := by
exact (toContinuousMultilinearMapCLM 𝕜).hasFDerivAt.comp x hf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change do anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Lean falls to unify the expression without this. Should I add a TODO?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ( :) also work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried yet. BTW, the ( :)s I removed stopped working.

@joneugster joneugster added the t-analysis Analysis (normed *, calculus) label Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants