-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(FDeriv/Comp): migrate to TVS #34867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Generalize some lemmas to the TVS setting. - Use `Topology.IsInducing` instead of `AntilipschitzWith` or `ContinuousLinearEquiv`.
PR summary b7a1849720Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
This PR/issue depends on:
|
|
!bench |
|
Benchmark results for e9eab3e against b7a1849 are in! @urkud
Large changes (1✅)
Medium changes (4🟥)
Small changes (1✅, 15🟥)
|
|
@eric-wieser This looks like a larger slowdown. Any ideas on how can we speed it up? |
|
Generalizing many downstream files too would help with that performance loss; perhaps you should start stacking PRs for the sake of benchmarking a slightly-more-complete refactor? |
| x := by | ||
| exact (toContinuousMultilinearMapCLM 𝕜).hasFDerivAt.comp x hf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Lean falls to unify the expression without this. Should I add a TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does ( :) also work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried yet. BTW, the ( :)s I removed stopped working.
Uh oh!
There was an error while loading. Please reload this page.