-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor(gcongr): split MVarId.gcongr into multiple functions
#34870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JovanGerb
wants to merge
12
commits into
leanprover-community:master
Choose a base branch
from
JovanGerb:Jovan-gcongrCore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(gcongr): split MVarId.gcongr into multiple functions
#34870
JovanGerb
wants to merge
12
commits into
leanprover-community:master
from
JovanGerb:Jovan-gcongrCore
+135
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary df5a622749Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
MVarId.gcongr into two functionsMVarId.gcongr into multiple functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
MVarId.gcongrinto multiple functions. Previously,MVarId.gcongrwas a bit too large of a function for readability/maintainability. We also add a new monadGCongrMin order to keep track of the state more conveniently.This change will make future improvements in
gcongreasier. This PR doesn't change any behaviour, but does add two TODO comments.Implementation notes:
MVarId.gcongrCorewill now always throw an exception when it doesn't succeed, and it is wrapped in a try-catch block to catch these if that is desired.saveStatewithgetMCtx, because the former didn't work in theGCongrMmonad, and the only thing we are interested in saving/reverting is the metavariable context anyways.