feat(translate): print constant names with hover info #35134
+46
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
PR summary 4071ce7432Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
JovanGerb
approved these changes
Feb 11, 2026
| -- if this declaration is not `pre` and not an internal declaration, we return an error, | ||
| -- since we should have already translated this declaration. | ||
| if src != pre && !src.isInternalDetail then | ||
| throwError "The declaration {pre} depends on the declaration {src} which is in the namespace \ |
Contributor
There was a problem hiding this comment.
Why not also use .ofConstname for pre?
| if res == src then | ||
| throwError "{t.attrName}: the generated translated name equals the original name '{src}'.\n\ | ||
| throwError "{t.attrName}: the generated translated name equals the original name \ | ||
| '{.ofConstName src}'.\n\ |
Contributor
There was a problem hiding this comment.
Suggested change
| '{.ofConstName src}'.\n\ | |
| `{.ofConstName src}`.\n\ |
Let's take this opportunity to use back-ticks. The advantage of backtics is that they cannot be part of declaration names, while ' can.
Arguably, we should consistently do this in the whole file.
| unless srcDecl.levelParams.length == tgtDecl.levelParams.length do | ||
| throwError "`{t.attrName}` validation failed:\n expected {srcDecl.levelParams.length} \ | ||
| universe levels, but '{tgt}' has {tgtDecl.levelParams.length} universe levels" | ||
| universe levels, but '{.ofConstName tgt}' has {tgtDecl.levelParams.length} \ |
Contributor
There was a problem hiding this comment.
Suggested change
| universe levels, but '{.ofConstName tgt}' has {tgtDecl.levelParams.length} \ | |
| universe levels, but `{.ofConstName tgt}` has {tgtDecl.levelParams.length} \ |
| throwError "`{t.attrName}` validation failed: expected{indentExpr srcType}\nbut '{tgt}' has \ | ||
| type{indentExpr tgtType}" | ||
| throwError "`{t.attrName}` validation failed: expected{indentExpr srcType}\n\ | ||
| but '{.ofConstName tgt}' has type{indentExpr tgtType}" |
Contributor
There was a problem hiding this comment.
Suggested change
| but '{.ofConstName tgt}' has type{indentExpr tgtType}" | |
| but `{.ofConstName tgt}` has type{indentExpr tgtType}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #34846.