feat(CategoryTheory/Triangulated): Rotated octahedron axiom#35496
feat(CategoryTheory/Triangulated): Rotated octahedron axiom#35496justus-springer wants to merge 8 commits intoleanprover-community:masterfrom
Conversation
PR summary f2bcf8c5f4Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 13075 | 2 | backward.isDefEq |
Current commit eee48a60cb
Reference commit f2bcf8c5f4
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
Could you investigate whether this rotated variant could be used in order to refactor (part of) the proof of mathlib4/Mathlib/CategoryTheory/Triangulated/Opposite/Triangulated.lean Lines 36 to 112 in 3c50db6 |
|
Indeed I could refactor the instance using the rotated variant (e196a39). |
The now duplicate definition `someOctahedron'` is removed. (The reason for its existence is related to some bug which occurred at the time of the port to Lean 3 #3072.) (No deprecated alias is added as it was only part of the implementation of `someOctahedron`, and we may want to reuse the name for #35496.)
|
This PR/issue depends on: |
|
This pull request has conflicts, please merge |
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
This PR adds an alternative version of the octahedron axiom in triangulated categories, where all triangles have been rotated. This is similar to how
distinguished_cocone_triangle₁is a rotated version ofdistinguished_cocone_triangle.I also added diagrams to the docstrings of both
OctahedronandOctahedron'.someOctahedron'#35501