Skip to content

Comments

feat(RingTheory/Valuation): add IsTrivialOn_lemmas#35503

Open
mariainesdff wants to merge 1 commit intomasterfrom
isTrivialOn_lemmas
Open

feat(RingTheory/Valuation): add IsTrivialOn_lemmas#35503
mariainesdff wants to merge 1 commit intomasterfrom
isTrivialOn_lemmas

Conversation

@mariainesdff
Copy link
Contributor

Co-authored by : @xgenereux


Open in Gitpod

@github-actions
Copy link

PR summary e98e5080e3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsTrivialOn.of_le_one
+ isTrivialOn
+ isTrivialOn_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Contributor

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer delegate

1 < v₁ x ↔ 1 < v₂ x := by
rw [← v₁.map_one, h.lt_iff_lt, map_one]

theorem isTrivialOn (A : Type*) [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem isTrivialOn (A : Type*) [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂)
theorem isTrivialOn {A : Type*} [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂)

(h₁ : IsTrivialOn A v₁) : IsTrivialOn A v₂ where
eq_one _ ha := h.eq_one_iff_eq_one.mp (IsTrivialOn.eq_one _ ha)

theorem isTrivialOn_iff (A : Type*) [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem isTrivialOn_iff (A : Type*) [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) :
theorem isTrivialOn_iff {A : Type*} [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) :

Comment on lines +112 to +113
theorem IsTrivialOn.of_le_one {O : Type w} [Field O] [Algebra O R] (v : Valuation R Γ₀)
(hle : ∀ (x : O), v (algebraMap O R x) ≤ 1) : v.IsTrivialOn O where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem IsTrivialOn.of_le_one {O : Type w} [Field O] [Algebra O R] (v : Valuation R Γ₀)
(hle : ∀ (x : O), v (algebraMap O R x) ≤ 1) : v.IsTrivialOn O where
theorem IsTrivialOn.of_le_one {k : Type*} [Field k] [Algebra k R] (v : Valuation R Γ₀)
(hle : ∀ (x : k), v (algebraMap k R x) ≤ 1) : v.IsTrivialOn k where

k seems like a more usual variable name for a field than O?

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 24, 2026
@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 24, 2026

✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants