feat(RingTheory/Valuation): add IsTrivialOn_lemmas#35503
Open
mariainesdff wants to merge 1 commit intomasterfrom
Open
feat(RingTheory/Valuation): add IsTrivialOn_lemmas#35503mariainesdff wants to merge 1 commit intomasterfrom
mariainesdff wants to merge 1 commit intomasterfrom
Conversation
PR summary e98e5080e3Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
chrisflav
approved these changes
Feb 24, 2026
Contributor
chrisflav
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
| 1 < v₁ x ↔ 1 < v₂ x := by | ||
| rw [← v₁.map_one, h.lt_iff_lt, map_one] | ||
|
|
||
| theorem isTrivialOn (A : Type*) [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) |
Contributor
There was a problem hiding this comment.
Suggested change
| theorem isTrivialOn (A : Type*) [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) | |
| theorem isTrivialOn {A : Type*} [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) |
| (h₁ : IsTrivialOn A v₁) : IsTrivialOn A v₂ where | ||
| eq_one _ ha := h.eq_one_iff_eq_one.mp (IsTrivialOn.eq_one _ ha) | ||
|
|
||
| theorem isTrivialOn_iff (A : Type*) [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) : |
Contributor
There was a problem hiding this comment.
Suggested change
| theorem isTrivialOn_iff (A : Type*) [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) : | |
| theorem isTrivialOn_iff {A : Type*} [CommSemiring A] [Algebra A R] (h : v₁.IsEquiv v₂) : |
Comment on lines
+112
to
+113
| theorem IsTrivialOn.of_le_one {O : Type w} [Field O] [Algebra O R] (v : Valuation R Γ₀) | ||
| (hle : ∀ (x : O), v (algebraMap O R x) ≤ 1) : v.IsTrivialOn O where |
Contributor
There was a problem hiding this comment.
Suggested change
| theorem IsTrivialOn.of_le_one {O : Type w} [Field O] [Algebra O R] (v : Valuation R Γ₀) | |
| (hle : ∀ (x : O), v (algebraMap O R x) ≤ 1) : v.IsTrivialOn O where | |
| theorem IsTrivialOn.of_le_one {k : Type*} [Field k] [Algebra k R] (v : Valuation R Γ₀) | |
| (hle : ∀ (x : k), v (algebraMap k R x) ≤ 1) : v.IsTrivialOn k where |
k seems like a more usual variable name for a field than O?
|
🚀 Pull request has been placed on the maintainer queue by chrisflav. |
Member
|
Thanks! bors d+ |
Contributor
|
✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored by : @xgenereux