Skip to content

Comments

feat(FieldTheory/Finite/Valuation): add IsTrivialOn#35531

Open
mariainesdff wants to merge 3 commits intomasterfrom
finite_field_valuation
Open

feat(FieldTheory/Finite/Valuation): add IsTrivialOn#35531
mariainesdff wants to merge 3 commits intomasterfrom
finite_field_valuation

Conversation

@mariainesdff
Copy link
Contributor

Co-authored with: @xgenereux.


Open in Gitpod

@mariainesdff mariainesdff added the t-algebra Algebra (groups, rings, fields, etc) label Feb 19, 2026
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

PR summary d9896de2ab

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.FieldTheory.Finite.Valuation (new file) 1687

Declarations diff

+ instance : IsTrivialOn Fq v
+ valuation_algebraMap_eq_one
+ valuation_algebraMap_le_one

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mariainesdff mariainesdff added the WIP Work in progress label Feb 19, 2026
@mariainesdff mariainesdff removed the WIP Work in progress label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants