feat(Torsion/Basic): Add a few convenient lemmas for torsion submodules#35534
Open
xgenereux wants to merge 2 commits intoleanprover-community:masterfrom
Open
feat(Torsion/Basic): Add a few convenient lemmas for torsion submodules#35534xgenereux wants to merge 2 commits intoleanprover-community:masterfrom
xgenereux wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary af97ef4b5bImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few convenient lemmas in Torsion/Basic.
In particular, it adds:
torsionBySet_span_singleton_eqfor Ideals. These two are added to the simp set.isTorsionBy/isTorsionBySetbeingIsTorsionin the form oftorsionBy_isTorsion_nonZeroDivisorandtorsionBySet_ideal_isTorsion_of_noZeroDivisors.iSup_torsionBySet_ideal_eq_torsionBySet_iInfandsupIndep_torsionBySet_idealforsupinstead ofiSup.Note: To go from
iSuptosupI need to talk aboutFin 2which requiresFinset.univ_fin2that is in Mathlib but in a weird place. I just put it as a have in my proof.Note2: one could also use
{P,Q}andidinstead of the map fromFin 2but that makes the proof ofdisjoint_torsionBySet_idealinconvenient.Co-authored-by: María Inés de Frutos Fernández <mariaines.dff@gmail.com>