perf: add AddMonoid shortcut instance for linear maps#35555
Open
JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Open
perf: add AddMonoid shortcut instance for linear maps#35555JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
AddMonoid shortcut instance for linear maps#35555JovanGerb wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary 08657ed7f8Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 13074 | 1 | backward.isDefEq |
Current commit e6921ef955
Reference commit 08657ed7f8
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
Author
|
!bench |
|
Benchmark results for e6921ef against 08657ed are in! @JovanGerb
Large changes (1✅)
Medium changes (20✅)
Small changes (40✅) Too many entries to display here. View the full report on radar instead. |
Contributor
Author
|
The longest pole has shortened by 1.2% 🎉 |
|
This pull request has conflicts, please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hierarchy of classes is such that
AddCommMonoidis not a direct parent ofAddCommGroup. This means that when unifying an instance that comes fromAddCommMonoidwith one that comes fromAddCommGroup, we end up having to go through the shared parentAddMonoid. Hence, it can be beneficial to have a separately definedAddMonoidinstance.It might be worth it to try to switch up the order of the parents of
AddCommGroup/CommGroupin theextendsclause, and see if that has beneficial effects. Though this will affect many things, and in particular won't interact well with thebackward.respectTransparencymess that is going on at the moment.