Skip to content

Comments

chore(Order/Defs/Unbundled): deprecate def Transitive in favor of class IsTrans#35592

Open
SnirBroshi wants to merge 4 commits intoleanprover-community:masterfrom
SnirBroshi:chore/relation-duplication/transitive
Open

chore(Order/Defs/Unbundled): deprecate def Transitive in favor of class IsTrans#35592
SnirBroshi wants to merge 4 commits intoleanprover-community:masterfrom
SnirBroshi:chore/relation-duplication/transitive

Conversation

@SnirBroshi
Copy link
Collaborator

@github-actions
Copy link

github-actions bot commented Feb 21, 2026

PR summary 332fc33e62

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Equivalence.isTrans
+ InvImage.isTrans
+ IsTrans.comap
+ isTrans
+ isTrans_join
+ isTrans_le
+ isTrans_lt
+ isTrans_manyOneReducible
+ isTrans_map
+ isTrans_oneOneReducible
+ reflTransGen_of_isTrans_reflexive
+ transitive_ge
+ transitive_gt
++-- LiftRel.equiv
++-- LiftRel.trans

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@SnirBroshi SnirBroshi added the t-order Order theory label Feb 21, 2026
Copy link
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants