Skip to content

Comments

chore(Topology/Order/OrderClosed): use to_dual#35638

Open
vihdzp wants to merge 2 commits intoleanprover-community:masterfrom
vihdzp:topology2
Open

chore(Topology/Order/OrderClosed): use to_dual#35638
vihdzp wants to merge 2 commits intoleanprover-community:masterfrom
vihdzp:topology2

Conversation

@vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Feb 22, 2026

@github-actions
Copy link

PR summary 74976248f9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ OrderClosedTopology.isClosed_le''
- BddBelow.closure
- BddBelow.of_closure
- Continuous.max
- CovBy.nhdsGE
- CovBy.nhdsGT
- Dense.exists_le
- Dense.exists_le'
- Dense.exists_lt
- Filter.Eventually.exists_gt
- Filter.Tendsto.eventually_le_const
- Filter.Tendsto.eventually_lt_const
- Filter.Tendsto.min
- Filter.Tendsto.min_left
- Filter.Tendsto.min_right
- Filter.tendsto_nhds_min_left
- Icc_mem_nhdsGE
- Icc_mem_nhdsGE_of_mem
- Icc_mem_nhdsGT
- Icc_mem_nhdsGT_of_mem
- Ico_mem_nhds
- Ico_mem_nhdsGE
- Ico_mem_nhdsGE_of_mem
- Ico_mem_nhdsGT
- Ico_mem_nhdsGT_of_mem
- Iic_mem_nhds
- Iio_mem_nhds
- Ioc_mem_nhdsGE_of_mem
- Ioc_mem_nhdsGT
- Ioc_mem_nhdsGT_of_mem
- Ioo_mem_nhdsGE_of_mem
- Ioo_mem_nhdsGT
- Ioo_mem_nhdsGT_of_mem
- IsClosed.hypograph
- IsGLB.range_of_tendsto
- SuccOrder.nhdsGE
- SuccOrder.nhdsGT
- SuccOrder.nhdsLE_eq_nhds
- SuccOrder.nhdsLT_eq_nhdsNE
- bddBelow_closure
- closure_Ici
- continuousWithinAt_Icc_iff_Ici
- continuousWithinAt_Ico_iff_Ici
- continuousWithinAt_Iio_iff_Iic
- continuousWithinAt_Ioc_iff_Ioi
- continuousWithinAt_Ioo_iff_Ioi
- continuousWithinAt_inter_Iio_iff_Iic
- continuous_max
- disjoint_nhds_atTop
- disjoint_nhds_atTop_iff
- eventually_le_nhds
- eventually_lt_nhds
- frequently_gt_nhds
- frontier_Ici_subset
- ge_of_tendsto
- ge_of_tendsto'
- ge_of_tendsto_of_frequently
- inf_nhds_atTop
- instance : ClosedIciTopology α
- instance : ClosedIicTopology αᵒᵈ
- interior_Iio
- isClosed_Ici
- isOpen_Iio
- lowerBounds_closure
- nhdsGE_neBot
- nhdsGT_le_nhdsNE
- nhdsWithin_Icc_eq_nhdsGE
- nhdsWithin_Ico_eq_nhdsGE
- nhdsWithin_Iic_neBot
- nhdsWithin_Ioc_eq_nhdsGT
- nhdsWithin_Ioo_eq_nhdsGT
- not_tendsto_atTop_of_tendsto_nhds
- not_tendsto_nhds_of_tendsto_atTop

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 22, 2026
@mathlib-dependent-issues
Copy link

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant