Skip to content

Comments

feat(RingTheory/Ideal/Quotient): add a canonical inclusion map#35647

Open
BryceT233 wants to merge 1 commit intoleanprover-community:masterfrom
BryceT233:powSmulQuotInclusion
Open

feat(RingTheory/Ideal/Quotient): add a canonical inclusion map#35647
BryceT233 wants to merge 1 commit intoleanprover-community:masterfrom
BryceT233:powSmulQuotInclusion

Conversation

@BryceT233
Copy link
Contributor

This is the second PR split from the larger PR #34936 to make the review process easier.

It introduces Submodule.powSmulQuotInclusion, which is the canonical inclusion from I ^ a • N ⧸ I ^ b • (I ^ a • N) to M ⧸ I ^ c • N where c = b + a, and provides auxiliary lemmas for it


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 22, 2026
@github-actions
Copy link

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link

PR summary 570ff68990

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ factorPow_powSmulQuotInclusion_comm
+ powSmulQuotInclusion
+ powSmulQuotInclusion_injective
+ powSmulQuotInclusion_range

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
13074 1 backward.isDefEq

Current commit c8f4fc044e
Reference commit 570ff68990

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant