[Merged by Bors] - fix(Linter/TextBased): don't flag "see adaptation note" comments#35668
Closed
[Merged by Bors] - fix(Linter/TextBased): don't flag "see adaptation note" comments#35668
Conversation
The `adaptationNoteLinter` was matching any line containing the substring "daptation note", which caused false positives on lines like `set_option maxHeartbeats 400000 in -- see adaptation note` that merely reference a nearby `#adaptation_note` command. Exclude lines containing `#adaptation_note` (correct usage) and lines containing `see adaptation note` (cross-references). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR summary 699a55a4e2Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
) This PR fixes the `adaptationNoteLinter` which was matching any line containing the substring `"daptation note"`, causing false positives on lines like: ```lean #adaptation_note /-- The maxHeartbeats bump is required after leanprover/lean4#12564. -/ set_option maxHeartbeats 400000 in -- see adaptation note ``` The linter now excludes lines containing `#adaptation_note` (correct usage) and `see adaptation note` (cross-references to a nearby `#adaptation_note` command). See https://github.com/leanprover-community/mathlib4-nightly-testing/actions/runs/22289522784/job/64474181031 for all 8 false positives, all of this form. 🤖 Prepared with Claude Code
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
) This PR fixes the `adaptationNoteLinter` which was matching any line containing the substring `"daptation note"`, causing false positives on lines like: ```lean #adaptation_note /-- The maxHeartbeats bump is required after leanprover/lean4#12564. -/ set_option maxHeartbeats 400000 in -- see adaptation note ``` The linter now excludes lines containing `#adaptation_note` (correct usage) and `see adaptation note` (cross-references to a nearby `#adaptation_note` command). See https://github.com/leanprover-community/mathlib4-nightly-testing/actions/runs/22289522784/job/64474181031 for all 8 false positives, all of this form. 🤖 Prepared with Claude Code
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Mar 2, 2026
…nprover-community#35668) This PR fixes the `adaptationNoteLinter` which was matching any line containing the substring `"daptation note"`, causing false positives on lines like: ```lean #adaptation_note /-- The maxHeartbeats bump is required after leanprover/lean4#12564. -/ set_option maxHeartbeats 400000 in -- see adaptation note ``` The linter now excludes lines containing `#adaptation_note` (correct usage) and `see adaptation note` (cross-references to a nearby `#adaptation_note` command). See https://github.com/leanprover-community/mathlib4-nightly-testing/actions/runs/22289522784/job/64474181031 for all 8 false positives, all of this form. 🤖 Prepared with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
adaptationNoteLinterwhich was matching any line containing the substring"daptation note", causing false positives on lines like:The linter now excludes lines containing
#adaptation_note(correct usage) andsee adaptation note(cross-references to a nearby#adaptation_notecommand).See https://github.com/leanprover-community/mathlib4-nightly-testing/actions/runs/22289522784/job/64474181031 for all 8 false positives, all of this form.
🤖 Prepared with Claude Code