chore: avoid passing explicit lemmas to grind and (terminal) simp_all where unnecessary#35693
Open
euprunin wants to merge 1 commit intoleanprover-community:masterfrom
Open
chore: avoid passing explicit lemmas to grind and (terminal) simp_all where unnecessary#35693euprunin wants to merge 1 commit intoleanprover-community:masterfrom
grind and (terminal) simp_all where unnecessary#35693euprunin wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 82ad986957Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective.
Trace profiling results (differences <30 ms considered measurement noise):
SimpleGraph.Walk.IsCycle.getVert_injOn: 684 ms before, 596 ms after 🎉List.HasPeriod.gcd: 846 ms before, 807 ms after 🎉List.Sublist.orderedInsert_sublist: unchanged 🎉Affine.Simplex.exists_forall_dist_eq_iff_exists_excenterExists_and_eq_excenter: unchanged 🎉Matrix.pow_apply_pos_iff_nonempty_path: unchanged 🎉RootPairing.Hom.coweightHom_injective: unchanged 🎉RootPairing.isReduced_iff': unchanged 🎉Set.Ico_eq_Ico_iff: unchanged 🎉Set.Ioc_eq_Ioc_iff: unchanged 🎉Profiled using
set_option trace.profiler true in.This PR is batched under the following guidelines: