Skip to content

feat(NumberTheory/Divisors): Add infinite_setOf_divisors_iff#35805

Open
adrianmartir wants to merge 2 commits intoleanprover-community:masterfrom
adrianmartir:adrianmartir-infinite-divisors
Open

feat(NumberTheory/Divisors): Add infinite_setOf_divisors_iff#35805
adrianmartir wants to merge 2 commits intoleanprover-community:masterfrom
adrianmartir:adrianmartir-infinite-divisors

Conversation

@adrianmartir
Copy link
Contributor

@adrianmartir adrianmartir commented Feb 26, 2026

This proves that the set of divisors { m | m | n } of a natural number n is infinite if and only if n is zero. The first proof draft was by @Aristotle-Harmonic.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 26, 2026
@github-actions
Copy link

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Feb 26, 2026
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@github-actions
Copy link

github-actions bot commented Feb 26, 2026

PR summary 0fbcb39f55

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ infinite_setOf_divisors_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adrianmartir adrianmartir changed the title feat(NumberTheory/Divisors): Add infinite_setOf_divisors. feat(NumberTheory/Divisors): Add infinite_setOf_divisors Feb 26, 2026
@alexjbest
Copy link
Member

The pr description is a bit confusing! It should have the other part of the iff in.

And this should probably be a @[simp] lemma

@adrianmartir adrianmartir changed the title feat(NumberTheory/Divisors): Add infinite_setOf_divisors feat(NumberTheory/Divisors): Add infinite_setOf_divisors_iff Mar 2, 2026
@adrianmartir adrianmartir force-pushed the adrianmartir-infinite-divisors branch from 369c54f to 5aefc07 Compare March 2, 2026 09:32
@adrianmartir
Copy link
Contributor Author

Indeed, I had written the PR description incorrectly. I fixed it now, renamed the lemma and added it as a simp lemma.

I also wasn't sure if this was the best place to put the lemma, since the file is mainly about Nat.divisors, which is not the same. However, it felt like it was the best place to put it, since I didn't find a suitable file in Data/Nat.

I also do have an integer version for the lemma, which I did not include here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants