review: (first pass) refactor traversal to make it more reviewable#35833
Conversation
PR summary d300915bf1Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 11957 | 1 | backward.isDefEq |
Current commit d18f23e60c
Reference commit d300915bf1
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
be3f919
into
leanprover-community:kim/check-defeq-abuse
This PR is very bulky, which makes it difficult to review the logic. Part of the issue here is using a bare continuation
gofor folding, and descending into children manually everywhere...which is fine for claude, but not so much for human reviewers!So, this PR cuts ~60 lines off of the main file so we can better see what's going on. Most of the +130 is documentation or just cleaner abstractions that make it more readable.