Skip to content

[Merged by Bors] - chore(CategoryTheory): reduce defeq abuse about Sets#35885

Closed
urkud wants to merge 3 commits intoleanprover-community:masterfrom
urkud:yury/set-defeq-category
Closed

[Merged by Bors] - chore(CategoryTheory): reduce defeq abuse about Sets#35885
urkud wants to merge 3 commits intoleanprover-community:masterfrom
urkud:yury/set-defeq-category

Conversation

@urkud
Copy link
Member

@urkud urkud commented Feb 28, 2026


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

PR summary edb32313f1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance (p : K → Prop) : HasCokernel (biproduct.fromSubtype f p)
+ instance (p : K → Prop) : HasKernel (biproduct.toSubtype f p)
- instance (p : Set K) : HasCokernel (biproduct.fromSubtype f p)
- instance (p : Set K) : HasKernel (biproduct.toSubtype f p)

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (12.00, 0.00)
Current number Change Type
11887 -12 backward.isDefEq

Current commit a1120b1001
Reference commit edb32313f1

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kim-em
Copy link
Contributor

kim-em commented Mar 1, 2026

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 1, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 1, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory): reduce defeq abuse about Sets [Merged by Bors] - chore(CategoryTheory): reduce defeq abuse about Sets Mar 1, 2026
@mathlib-bors mathlib-bors bot closed this Mar 1, 2026
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
@urkud urkud deleted the yury/set-defeq-category branch March 5, 2026 08:15
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 10, 2026
pevogam pushed a commit to pevogam/mathlib4 that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants