Skip to content

chore: use the API instead of the definition on Equiv.ofBijective#36191

Open
riccardobrasca wants to merge 4 commits intoleanprover-community:masterfrom
riccardobrasca:RB/equiv_bij
Open

chore: use the API instead of the definition on Equiv.ofBijective#36191
riccardobrasca wants to merge 4 commits intoleanprover-community:masterfrom
riccardobrasca:RB/equiv_bij

Conversation

@riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Mar 5, 2026

We modify declarations that use the actual definition of Equiv.ofBijective instead on relying on the API. With these modifications mathlib compiles with

noncomputable def ofBijective (f : α → β) (hf : Bijective f) : α ≃ β where
  toFun := f
  invFun := sorry
  left_inv := sorry
  right_inv := sorry

Open in Gitpod

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR summary 45362d78ed

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-logic Logic (model theory, etc) label Mar 5, 2026
@riccardobrasca riccardobrasca changed the title try chore: use the API instead of the definition on Equiv.of_bijective Mar 5, 2026
@riccardobrasca riccardobrasca added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 5, 2026
@riccardobrasca riccardobrasca marked this pull request as ready for review March 5, 2026 13:45
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 5, 2026
@Ruben-VandeVelde Ruben-VandeVelde changed the title chore: use the API instead of the definition on Equiv.of_bijective chore: use the API instead of the definition on Equiv.ofBijective Mar 5, 2026
Copy link
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-logic Logic (model theory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants