Skip to content

feat(CategoryTheory): characterize pullback squares via the Over category#36216

Open
michaellee94 wants to merge 2 commits intoleanprover-community:masterfrom
michaellee94:michaellee94/overPullback_iff
Open

feat(CategoryTheory): characterize pullback squares via the Over category#36216
michaellee94 wants to merge 2 commits intoleanprover-community:masterfrom
michaellee94:michaellee94/overPullback_iff

Conversation

@michaellee94
Copy link
Collaborator


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions bot added t-category-theory Category theory large-import Automatically added label for PRs with a significant increase in transitive imports labels Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR summary 3a4b36f227

Import changes exceeding 2%

% File
+34.29% Mathlib.CategoryTheory.Comma.Over.Pullback

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Comma.Over.Pullback 455 611 +156 (+34.29%)
Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Abelian.Preradical.Basic 1
3 files Mathlib.CategoryTheory.Monoidal.Closed.Ideal Mathlib.CategoryTheory.Subobject.MonoOver Mathlib.CategoryTheory.Subterminal
3
4 files Mathlib.CategoryTheory.LocallyCartesianClosed.ChosenPullbacksAlong Mathlib.CategoryTheory.LocallyCartesianClosed.ExponentiableMorphism Mathlib.CategoryTheory.LocallyCartesianClosed.Over Mathlib.CategoryTheory.LocallyCartesianClosed.Sections
4
Mathlib.CategoryTheory.Comma.Over.Pullback 156

Declarations diff

+ isoOverPullback
+ ofIsoOverPullback
+ overPullback_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@michaellee94
Copy link
Collaborator Author

+34.29% Mathlib.CategoryTheory.Comma.Over.Pullback

Would it be better for this to go somewhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant