Skip to content

[Merged by Bors] - feat: generalize some ContinuousMul hypotheses to SeparatelyContinuousMul#36562

Closed
j-loreaux wants to merge 1 commit intoleanprover-community:masterfrom
j-loreaux:generalize-separatelyContinuousMul
Closed

[Merged by Bors] - feat: generalize some ContinuousMul hypotheses to SeparatelyContinuousMul#36562
j-loreaux wants to merge 1 commit intoleanprover-community:masterfrom
j-loreaux:generalize-separatelyContinuousMul

Conversation

@j-loreaux
Copy link
Contributor

@j-loreaux j-loreaux requested a review from eric-wieser March 12, 2026 20:43
Comment on lines -68 to +69
instance instContinuousSMul : ContinuousSMul G (G ⧸ N) where
instance instContinuousSMul {G : Type*} [Group G] [TopologicalSpace G] [ContinuousMul G]
{N : Subgroup G} : ContinuousSMul G (G ⧸ N) where
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just shadowing the variables because ContinuousMul really is necessary here, but none of the other results in this section need it.

@j-loreaux j-loreaux added the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 12, 2026
@github-actions
Copy link

PR summary 1049ae22f7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance (priority := 100) ContinuousMul.measurableMul [Mul γ] [SeparatelyContinuousMul γ] :
+ instance [SeparatelyContinuousMul G] (U : OpenSubgroup G) : DiscreteTopology (G ⧸ U.toSubgroup)
+ instance [SeparatelyContinuousMul G] : Lattice (OpenNormalSubgroup G)
+ instance [SeparatelyContinuousMul G] : Max (OpenNormalSubgroup G)
+ instance [SeparatelyContinuousMul G] [CompactSpace G] (U : OpenSubgroup G) :
- instance (priority := 100) ContinuousMul.measurableMul [Mul γ] [ContinuousMul γ] :
- instance [ContinuousMul G] (U : OpenSubgroup G) : DiscreteTopology (G ⧸ U.toSubgroup)
- instance [ContinuousMul G] : Lattice (OpenNormalSubgroup G)
- instance [ContinuousMul G] : Max (OpenNormalSubgroup G)
- instance [ContinuousMul G] [CompactSpace G] (U : OpenSubgroup G) : Finite (G ⧸ U.toSubgroup)

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 13, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 13, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: generalize some ContinuousMul hypotheses to SeparatelyContinuousMul [Merged by Bors] - feat: generalize some ContinuousMul hypotheses to SeparatelyContinuousMul Mar 13, 2026
@mathlib-bors mathlib-bors bot closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants