[Merged by Bors] - ci: get cache for parent commit, try 2 (revert #36608)#36623
Closed
bryangingechen wants to merge 8 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - ci: get cache for parent commit, try 2 (revert #36608)#36623bryangingechen wants to merge 8 commits intoleanprover-community:masterfrom
bryangingechen wants to merge 8 commits intoleanprover-community:masterfrom
Conversation
github-actions
bot
added
the
CI
PR summary 709cd81678Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
Workflow documentation reminderThis PR modifies files under Modified workflow files:
|
Contributor
|
Ok, let's try again! I can't monitor the result, though, so I'm delegating. bors d+ |
Contributor
|
✌️ bryangingechen can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-triage
bot
added
the
delegated
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
After #36614, the changes from #33044 should be OK again. This reverts commit 911abcf. Cf. [#mathlib4 > Mathlib has moved to the new module system @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Mathlib.20has.20moved.20to.20the.20new.20module.20system/near/579345546)
Contributor
Author
|
bors r- |
Contributor
|
Canceled. |
mathlib-triage
bot
removed
ready-to-merge
bryangingechen
added
the
awaiting-author
Contributor
Author
|
We had to revert the leantar update in #336614; I'll merge after we figure out what's going on. |
…6608) After leanprover-community#36614, the changes from leanprover-community#33044 should be OK again. This reverts commit 911abcf.
bryangingechen
force-pushed
the
get-parent-cache-2026-03-13
branch
from
f0c895d to
96a72f8
Compare
Contributor
Author
|
bors try |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
With the update to leantar v0.1.17, the changes from #33044 should be OK again. This reverts commit 911abcf. Cf. [#mathlib4 > Mathlib has moved to the new module system @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Mathlib.20has.20moved.20to.20the.20new.20module.20system/near/579345546)
Contributor
Author
|
bors try |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
With the update to leantar v0.1.17, the changes from #33044 should be OK again. This reverts commit 911abcf. Cf. [#mathlib4 > Mathlib has moved to the new module system @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Mathlib.20has.20moved.20to.20the.20new.20module.20system/near/579345546)
Contributor
Contributor
Author
|
OK, I believe https://github.com/leanprover-community/mathlib4/actions/runs/23075369138/job/67034465629#step:33:33 is a test showing cache upload works with v0.1.17. Let me try once again. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2026
With the update to leantar v0.1.17, the changes from #33044 should be OK again. This reverts commit 911abcf. Cf. [#mathlib4 > Mathlib has moved to the new module system @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Mathlib.20has.20moved.20to.20the.20new.20module.20system/near/579345546)
mathlib-triage
bot
added
ready-to-merge
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2026
…hain (#37653) #37564 changed `cache` so that it looks for a bundled `leantar` rather than downloading a copy. This caused the "warmup cache" step introduced in #36623 to break since the "previous" commit being fetched could be using an older toolchain. We fix this by simply skipping getting the cache for the previous commit if the toolchain differs. It's likely that the oleans are all invalidated anyways. Prepared with claude code.
riccardobrasca
pushed a commit
to riccardobrasca/mathlib4
that referenced
this pull request
Apr 6, 2026
…hain (leanprover-community#37653) leanprover-community#37564 changed `cache` so that it looks for a bundled `leantar` rather than downloading a copy. This caused the "warmup cache" step introduced in leanprover-community#36623 to break since the "previous" commit being fetched could be using an older toolchain. We fix this by simply skipping getting the cache for the previous commit if the toolchain differs. It's likely that the oleans are all invalidated anyways. Prepared with claude code.
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Apr 6, 2026
…hain (leanprover-community#37653) leanprover-community#37564 changed `cache` so that it looks for a bundled `leantar` rather than downloading a copy. This caused the "warmup cache" step introduced in leanprover-community#36623 to break since the "previous" commit being fetched could be using an older toolchain. We fix this by simply skipping getting the cache for the previous commit if the toolchain differs. It's likely that the oleans are all invalidated anyways. Prepared with claude code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the update to leantar v0.1.17, the changes from #33044 should be OK again.
This reverts commit 911abcf.
Cf. #mathlib4 > Mathlib has moved to the new module system @ 💬