feat(Order): OrderType.lift and more order type API#36720
feat(Order): OrderType.lift and more order type API#36720YanYablonovskiy wants to merge 8 commits intoleanprover-community:masterfrom
OrderType.lift and more order type API#36720Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 09d467d787Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Mathlib/Order/Types/Defs.lean
Outdated
| theorem type_uLift : type (ULift.{v, u} α) = lift.{v} (type α) := by | ||
| rfl |
There was a problem hiding this comment.
| theorem type_uLift : type (ULift.{v, u} α) = lift.{v} (type α) := by | |
| rfl | |
| theorem type_uLift : type (ULift.{v, u} α) = lift.{v} (type α) := rfl |
There was a problem hiding this comment.
It is bizarre, the term Eq.refl (type (ULift.{v, u} α)) is accepted, however rfl fails with
type (ULift.{v, u} α)
is not definitionally equal to the right-hand side
lift.{v, u} (type α)
Note: This theorem is exported from the current module. This requires that all definitions that need to be unfolded to prove this theorem must be exposed.```
There was a problem hiding this comment.
Is this because you are missing @[expose] on one of the relevant definitions?
There was a problem hiding this comment.
Perhaps it is because type is @[no_expose]
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
-awaiting-author |
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. trigger_name: pull_request_review |
Adding the universe lifting operation to
OrderType, addresses a 'TODO' .