Skip to content

[Merged by Bors] - chore(*): remove some set_option linter.flexible false#36738

Closed
vlad902 wants to merge 1 commit intoleanprover-community:masterfrom
vlad902:flexible-linter5
Closed

[Merged by Bors] - chore(*): remove some set_option linter.flexible false#36738
vlad902 wants to merge 1 commit intoleanprover-community:masterfrom
vlad902:flexible-linter5

Conversation

@vlad902
Copy link
Copy Markdown
Collaborator

@vlad902 vlad902 commented Mar 16, 2026

These set_options are derived from the fact that prior to #29027, linarith and nlinarith were not properly marked as flexible.


Open in Gitpod

As of leanprover-community#29027 linarith and nlinarith are flexible and these `set_option`s
are unnecessary.
@github-actions
Copy link
Copy Markdown

PR summary e8bf9c4436

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (4.00, 0.03)
Current number Change Type
127 -4 flexible linter exceptions

Current commit 6f0fc1930f
Reference commit e8bf9c4436

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vlad902 vlad902 changed the title fix(*): remove some set_option linter.flexible false chore(*): remove some set_option linter.flexible false Mar 16, 2026
@vlad902 vlad902 added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Mar 16, 2026
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 16, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 16, 2026
These `set_option`s are derived from the fact that prior to #29027, linarith and nlinarith were not properly marked as flexible.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(*): remove some set_option linter.flexible false [Merged by Bors] - chore(*): remove some set_option linter.flexible false Mar 16, 2026
@mathlib-bors mathlib-bors bot closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants