Skip to content

[Merged by Bors] - feat(Data/Nat/Factorization/Defs): more theorems about f.prod (· ^ ·)#36792

Closed
SnirBroshi wants to merge 5 commits intoleanprover-community:masterfrom
SnirBroshi:feature/number-theory/factorization-prod-pow-lemmas
Closed

[Merged by Bors] - feat(Data/Nat/Factorization/Defs): more theorems about f.prod (· ^ ·)#36792
SnirBroshi wants to merge 5 commits intoleanprover-community:masterfrom
SnirBroshi:feature/number-theory/factorization-prod-pow-lemmas

Conversation

@SnirBroshi
Copy link
Collaborator

@SnirBroshi SnirBroshi commented Mar 18, 2026

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

PR summary 034c50cbf6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ dvd_iff_exists_le_factorization
+ dvd_prod_pow_of_factorization_le
+ factorization_prod_pow_eq_self_of_le_factorization
+ prod_pow_dvd_of_le_factorization

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@SnirBroshi SnirBroshi changed the title Feature/number theory/factorization prod pow lemmas feat(Data/Nat/Factorization/Defs): more theorems about f.prod (· ^ ·) Mar 18, 2026
@mathlib-dependent-issues
Copy link

@SnirBroshi SnirBroshi force-pushed the feature/number-theory/factorization-prod-pow-lemmas branch from 8c5c863 to afcad75 Compare March 18, 2026 06:18
@SnirBroshi SnirBroshi added the t-data Data (lists, quotients, numbers, etc) label Mar 18, 2026
Copy link
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo a naming issue.

maintainer delegate

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.


pull_request_review, wf_run

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 18, 2026
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@Vierkantor
Copy link
Contributor

Oops, I mean:

bors r-

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 18, 2026

✌️ SnirBroshi can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 18, 2026
@Vierkantor Vierkantor removed the ready-to-merge This PR has been sent to bors. label Mar 18, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 18, 2026

Canceled.

@mathlib-triage mathlib-triage bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). labels Mar 18, 2026
@SnirBroshi
Copy link
Collaborator Author

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 19, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Nat/Factorization/Defs): more theorems about f.prod (· ^ ·) [Merged by Bors] - feat(Data/Nat/Factorization/Defs): more theorems about f.prod (· ^ ·) Mar 19, 2026
@mathlib-bors mathlib-bors bot closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants