[Merged by Bors] - refactor(Combinatorics/SimpleGraph): make the vertex argument explicit in Walk.rotate#36800
Closed
YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
Closed
Conversation
…t in `Walk.rotate` It is annoying for it not to appear in the infoview. In general, no implicit data argument to a definition should be inferrable only through proof arguments.
PR summary 2352820370Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
1 task
Contributor
Could do, but I think the current PR is an improvement regardless, so let's investigate this in follow-up PRs. Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
…t in `Walk.rotate` (#36800) It is annoying for it not to appear in the infoview. In general, no implicit data argument to a definition should be inferrable only through proof arguments.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Walk.rotateWalk.rotate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is annoying for it not to appear in the infoview. In general, no implicit data argument to a definition should be inferrable only through proof arguments.
I could further remove the proof obligation by making
Walk.rotatereturn the original walk if the vertex is not in the support. What do you think?