Skip to content

[Merged by Bors] - refactor(Combinatorics/SimpleGraph): make the vertex argument explicit in Walk.rotate#36800

Closed
YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
YaelDillies:walk_rotate_explicit
Closed

[Merged by Bors] - refactor(Combinatorics/SimpleGraph): make the vertex argument explicit in Walk.rotate#36800
YaelDillies wants to merge 2 commits intoleanprover-community:masterfrom
YaelDillies:walk_rotate_explicit

Conversation

@YaelDillies
Copy link
Contributor

It is annoying for it not to appear in the infoview. In general, no implicit data argument to a definition should be inferrable only through proof arguments.


I could further remove the proof obligation by making Walk.rotate return the original walk if the vertex is not in the support. What do you think?

Open in Gitpod

…t in `Walk.rotate`

It is annoying for it not to appear in the infoview. In general, no implicit data argument to a definition should be inferrable only through proof arguments.
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

PR summary 2352820370

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@b-mehta
Copy link
Contributor

b-mehta commented Mar 18, 2026

I could further remove the proof obligation by making Walk.rotate return the original walk if the vertex is not in the support. What do you think?

Could do, but I think the current PR is an improvement regardless, so let's investigate this in follow-up PRs. Thanks!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Mar 18, 2026
…t in `Walk.rotate` (#36800)

It is annoying for it not to appear in the infoview. In general, no implicit data argument to a definition should be inferrable only through proof arguments.
@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 18, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 18, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Combinatorics/SimpleGraph): make the vertex argument explicit in Walk.rotate [Merged by Bors] - refactor(Combinatorics/SimpleGraph): make the vertex argument explicit in Walk.rotate Mar 18, 2026
@mathlib-bors mathlib-bors bot closed this Mar 18, 2026
@YaelDillies YaelDillies deleted the walk_rotate_explicit branch March 18, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants