Skip to content

[Merged by Bors] - chore(Analysis/SpecificLimits): rename tsum_geometric_nnreal to NNReal.tsum_geometric#36831

Closed
KryptosAI wants to merge 1 commit intoleanprover-community:masterfrom
KryptosAI:rename-tsum-geometric-nnreal
Closed

[Merged by Bors] - chore(Analysis/SpecificLimits): rename tsum_geometric_nnreal to NNReal.tsum_geometric#36831
KryptosAI wants to merge 1 commit intoleanprover-community:masterfrom
KryptosAI:rename-tsum-geometric-nnreal

Conversation

@KryptosAI
Copy link
Contributor

@KryptosAI KryptosAI commented Mar 18, 2026

Rename tsum_geometric_nnreal to NNReal.tsum_geometric for consistency with ENNReal.tsum_geometric.

A deprecated alias is added for backwards compatibility.

Addresses the tsum_geometric_nnrealNNReal.tsum_geometric item in #21584.


AI disclosure

I used Claude Code to explore the codebase (finding references, checking naming conventions) and to draft the PR description. I reviewed and understand all changes — this is a straightforward rename with a deprecated alias.

…Real.tsum_geometric`

Rename `tsum_geometric_nnreal` to `NNReal.tsum_geometric` for consistency
with the naming convention of placing the type namespace prefix before
the lemma name (matching `NNReal.hasSum_geometric` and
`NNReal.summable_geometric` which are defined just above).

A deprecated alias is added for backwards compatibility.

Addresses part of leanprover-community#21584.
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Mar 18, 2026
@github-actions
Copy link

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link

PR summary 0005884cdc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ NNReal.tsum_geometric

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Mar 18, 2026
@j-loreaux
Copy link
Contributor

j-loreaux commented Mar 20, 2026

I used Claude Code to explore the codebase (finding references, checking naming conventions) and to draft the PR description. I reviewed and understand all changes — this is a straightforward rename with a deprecated alias.

@KryptosAI You may be capable of understand the changes, but you obviously didn't bother to review the PR description, as it was complete nonsense. I have edited it appropriately, please see my edits.

Don't let your LLM generate garbage for reviewers to deal with. We have much more contributor bandwidth than we do review capacity, so any time reviewers waste on AI slop is a serious burden to this community. The problem is, you could have written the PR description in about 30 seconds, but now I've wasted several minutes checking it, finding out that it was wrong, going to the figure out what is the truth, and then editing it myself, and now writing this message in the hopes 🤞 that the message is received.

This is a warning, but if I find that this happens repeatedly with PRs from you I'll just close them.

@j-loreaux
Copy link
Contributor

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 20, 2026
@j-loreaux j-loreaux added LLM-generated PRs with substantial input from LLMs - review accordingly and removed ready-to-merge This PR has been sent to bors. labels Mar 20, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 20, 2026
…Real.tsum_geometric` (#36831)

Rename `tsum_geometric_nnreal` to `NNReal.tsum_geometric` for consistency with `ENNReal.tsum_geometric`.

A deprecated alias is added for backwards compatibility.

Addresses the `tsum_geometric_nnreal` → `NNReal.tsum_geometric` item in #21584.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 20, 2026

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Mar 20, 2026
…Real.tsum_geometric` (#36831)

Rename `tsum_geometric_nnreal` to `NNReal.tsum_geometric` for consistency with `ENNReal.tsum_geometric`.

A deprecated alias is added for backwards compatibility.

Addresses the `tsum_geometric_nnreal` → `NNReal.tsum_geometric` item in #21584.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 20, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/SpecificLimits): rename tsum_geometric_nnreal to NNReal.tsum_geometric [Merged by Bors] - chore(Analysis/SpecificLimits): rename tsum_geometric_nnreal to NNReal.tsum_geometric Mar 20, 2026
@mathlib-bors mathlib-bors bot closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LLM-generated PRs with substantial input from LLMs - review accordingly new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants