[Merged by Bors] - chore(Analysis/SpecificLimits): rename tsum_geometric_nnreal to NNReal.tsum_geometric#36831
Conversation
…Real.tsum_geometric` Rename `tsum_geometric_nnreal` to `NNReal.tsum_geometric` for consistency with the naming convention of placing the type namespace prefix before the lemma name (matching `NNReal.hasSum_geometric` and `NNReal.summable_geometric` which are defined just above). A deprecated alias is added for backwards compatibility. Addresses part of leanprover-community#21584.
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 0005884cdcImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
@KryptosAI You may be capable of understand the changes, but you obviously didn't bother to review the PR description, as it was complete nonsense. I have edited it appropriately, please see my edits. Don't let your LLM generate garbage for reviewers to deal with. We have much more contributor bandwidth than we do review capacity, so any time reviewers waste on AI slop is a serious burden to this community. The problem is, you could have written the PR description in about 30 seconds, but now I've wasted several minutes checking it, finding out that it was wrong, going to the figure out what is the truth, and then editing it myself, and now writing this message in the hopes 🤞 that the message is received. This is a warning, but if I find that this happens repeatedly with PRs from you I'll just close them. |
|
bors merge |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Pull request successfully merged into master. Build succeeded:
|
tsum_geometric_nnreal to NNReal.tsum_geometrictsum_geometric_nnreal to NNReal.tsum_geometric
Rename
tsum_geometric_nnrealtoNNReal.tsum_geometricfor consistency withENNReal.tsum_geometric.A deprecated alias is added for backwards compatibility.
Addresses the
tsum_geometric_nnreal→NNReal.tsum_geometricitem in #21584.AI disclosure
I used Claude Code to explore the codebase (finding references, checking naming conventions) and to draft the PR description. I reviewed and understand all changes — this is a straightforward rename with a deprecated alias.