Skip to content

[Merged by Bors] - chore: modulize tests (3/N)#36882

Closed
Komyyy wants to merge 1 commit intoleanprover-community:masterfrom
Komyyy:modulize-tests-3
Closed

[Merged by Bors] - chore: modulize tests (3/N)#36882
Komyyy wants to merge 1 commit intoleanprover-community:masterfrom
Komyyy:modulize-tests-3

Conversation

@Komyyy
Copy link
Copy Markdown
Contributor

@Komyyy Komyyy commented Mar 20, 2026


Privately imports are intentional.

I manually modulize each test so that the purpose of the tests is not lost by modulizing.

This PR is extracted from draft PR #34466.
These tests are for tactics, which can modulize by simply adding module.

Open in Gitpod

---

Privately imports are intentional.

I manually modulize each test so that the purpose of the tests is not lost by modulizing.

This PR is extracted from draft PR leanprover-community#34466.
These tests are for tactics, which can modulize by simply adding `module`.
@Komyyy Komyyy added the CI Modifies the continuous integration setup or other automation label Mar 20, 2026
@github-actions
Copy link
Copy Markdown

PR summary df9563a762

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 20, 2026
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 20, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 20, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: modulize tests (3/N) [Merged by Bors] - chore: modulize tests (3/N) Mar 20, 2026
@mathlib-bors mathlib-bors bot closed this Mar 20, 2026
@Komyyy Komyyy deleted the modulize-tests-3 branch March 20, 2026 01:49
@Komyyy Komyyy mentioned this pull request Mar 20, 2026
8 tasks
justus-springer pushed a commit to justus-springer/mathlib4 that referenced this pull request Mar 28, 2026
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants