Skip to content

feat(Geometry/Convex/Cone): Rename PointedCone.span to PointedCone.hull#36953

Open
martinwintermath wants to merge 3 commits intoleanprover-community:masterfrom
martinwintermath:cone-span-to-hull
Open

feat(Geometry/Convex/Cone): Rename PointedCone.span to PointedCone.hull#36953
martinwintermath wants to merge 3 commits intoleanprover-community:masterfrom
martinwintermath:cone-span-to-hull

Conversation

@martinwintermath
Copy link
Contributor

@martinwintermath martinwintermath commented Mar 21, 2026

Rename PointedCone.span to PointedCone.hull. Also adjusting cone lemma names and doc-strings.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Mar 21, 2026

PR summary ae57752bdf

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ dual_hull
+ mem_hull_set
+ subset_hull
++ hull
- dual_span
- mem_span_set
- subset_span
-- span

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-convex-geometry Affine geometry, cones, simplices label Mar 21, 2026
@martinwintermath martinwintermath marked this pull request as ready for review March 21, 2026 17:12
Copy link
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run scripts/add_deprecations.sh. Looks good otherwise!

maintainer delegate

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.


pull_request_review, wf_run

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-convex-geometry Affine geometry, cones, simplices

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants